Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Make TTL configurable through CLI args and docs fixes #3339

Closed
wants to merge 4 commits into from
Closed

WIP: Make TTL configurable through CLI args and docs fixes #3339

wants to merge 4 commits into from

Conversation

Haleshot
Copy link
Contributor

@Haleshot Haleshot commented Jan 3, 2025

📝 Summary

Fix #3329

🔍 Description of Changes

Make changes as per Akshay's comment for adding CLI args

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

@Haleshot Haleshot marked this pull request as draft January 3, 2025 22:52
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 1:38am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 4, 2025 1:38am

@Haleshot Haleshot changed the title add: Make TTL configurable through CLI args and docs fixes WIP: Make TTL configurable through CLI args and docs fixes Jan 3, 2025
akshayka
akshayka reviewed Jan 4, 2025
View reviewed changes
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs fixes! Two comments.

docs/api/inputs/button.md Outdated Show resolved Hide resolved
docs/api/inputs/run_button.md Outdated Show resolved Hide resolved
@Haleshot Haleshot closed this Jan 4, 2025
@Haleshot Haleshot mentioned this pull request Jan 4, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayka akshayka akshayka left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Configuration Option to Change Session TTL
2 participants
@Haleshot @akshayka