fix: handle marimo[extras] in --sandbox and package installation #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucharo
reviewed
Jan 14, 2025
| ) == ["numpy", "marimo[extras]>=0.1.0"] | ||
|
|
||
| # Test adding version when none exists | ||
| assert _normalize_sandbox_dependencies( |
There was a problem hiding this comment.
would it be worthwhile to add a case for several marimo extra dependencies? What would the behaviour be in that case? or will that edge case never happen the way dependencies are added one by one?
extra test case:
assert _normalize_sandbox_dependencies(
["marimo[extras]>=0.1.0", "marimo[sql]>=0.1.0", "numpy"], "1.0.0"
) == ["numpy", ???] There was a problem hiding this comment.
to add multiple extras, you declare them as marimo[extra1,extra2]. I am not sure if uv or other packages managers will merge this for you so you don't get into a bad state like that
akshayka
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few fixes to be more resilient with
--sandbox.marimo[sql]in the UI, we don't include the version (same asmarimo)marimoand anymarimo[extras], and add the version correctly.