Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: marimo edit --watch #3437

Merged
merged 5 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions docs/guides/editor_features/watching.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Watching notebooks

marimo's `--watch` flag enables a file watcher that automatically sync your
notebook file with the marimo editor or running application.

This allows you to edit your notebook file in the editor of your choice, and
have the changes automatically reflected in the running editor or application.

!!! tip "Install watchdog for better file watching"
For better file watching performance, install watchdog with `pip install watchdog`. Without watchdog, marimo will poll for file changes which is less efficient.

## `marimo run --watch`

When you run a notebook with the `--watch` flag, whenever the file watcher
detects a change to the notebook file, the application will be refreshed.
The browser will trigger a page refresh to ensure your notebook starts from a fresh state.

## `marimo watch --watch`

When you edit a notebook file with the `--watch` flag, whenever the file watcher
detects a change to the notebook file, the new cells and code changes will be streamed to
the browser editor.

This code will not be executed until you run the cell, and instead marked as stale.

## Watching for data changes

!!! note
Support for watching data files and automatically refreshing cells that depend on them is coming soon. Follow along at <https://github.com/marimo-team/marimo/issues/3258>
22 changes: 21 additions & 1 deletion frontend/src/core/cells/__tests__/cells.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1305,9 +1305,29 @@ describe("cell reducer", () => {
actions.setCellIds({ cellIds: newIds });
expect(state.cellIds.atOrThrow(FIRST_COLUMN).topLevelIds).toEqual(newIds);

actions.setCellCodes({ codes: newCodes, ids: newIds });
// When codeIsStale is false, lastCodeRun should match code
actions.setCellCodes({
codes: newCodes,
ids: newIds,
codeIsStale: false,
});
newIds.forEach((id, index) => {
expect(state.cellData[id].code).toBe(newCodes[index]);
expect(state.cellData[id].lastCodeRun).toBe(newCodes[index]);
expect(state.cellData[id].edited).toBe(false);
});

// When codeIsStale is true, lastCodeRun should not change
const staleCodes = ["stale1", "stale2", "stale3"];
actions.setCellCodes({
codes: staleCodes,
ids: newIds,
codeIsStale: true,
});
newIds.forEach((id, index) => {
expect(state.cellData[id].code).toBe(staleCodes[index]);
expect(state.cellData[id].lastCodeRun).toBe(newCodes[index]);
expect(state.cellData[id].edited).toBe(true);
});
});

Expand Down
26 changes: 22 additions & 4 deletions frontend/src/core/cells/cells.ts
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,10 @@ const {
cellHandles: nextCellHandles,
};
},
setCellCodes: (state, action: { codes: string[]; ids: CellId[] }) => {
setCellCodes: (
state,
action: { codes: string[]; ids: CellId[]; codeIsStale: boolean },
) => {
invariant(
action.codes.length === action.ids.length,
"Expected codes and ids to have the same length",
Expand All @@ -791,11 +794,26 @@ const {
const code = action.codes[i];

state = updateCellData(state, cellId, (cell) => {
// No change
if (cell.code.trim() === code.trim()) {
return cell;
}

// Update codemirror if mounted
const cellHandle = state.cellHandles[cellId].current;
if (cellHandle?.editorView) {
updateEditorCodeFromPython(cellHandle.editorView, code);
}

// If code is stale, we don't promote it to lastCodeRun
const lastCodeRun = action.codeIsStale ? cell.lastCodeRun : code;

return {
...cell,
code,
edited: false,
lastCodeRun: code,
code: code,
// Mark as edited if the code has changed
edited: lastCodeRun ? lastCodeRun.trim() !== code.trim() : false,
lastCodeRun,
};
});
}
Expand Down
1 change: 1 addition & 0 deletions frontend/src/core/websocket/useMarimoWebSocket.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ export function useMarimoWebSocket(opts: {
setCellCodes({
codes: msg.data.codes,
ids: msg.data.cell_ids as CellId[],
codeIsStale: msg.data.code_is_stale,
});
return;
case "update-cell-ids":
Expand Down
11 changes: 10 additions & 1 deletion marimo/_cli/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,14 @@ def main(
help=sandbox_message,
)
@click.option("--profile-dir", default=None, type=str, hidden=True)
@click.option(
"--watch",
is_flag=True,
default=False,
show_default=True,
type=bool,
help="Watch the file for changes and reload the code when saved in another editor.",
)
@click.argument("name", required=False, type=click.Path())
@click.argument("args", nargs=-1, type=click.UNPROCESSED)
def edit(
Expand All @@ -300,6 +308,7 @@ def edit(
skip_update_check: bool,
sandbox: bool,
profile_dir: Optional[str],
watch: bool,
name: Optional[str],
args: tuple[str, ...],
) -> None:
Expand Down Expand Up @@ -369,7 +378,7 @@ def edit(
headless=headless,
mode=SessionMode.EDIT,
include_code=True,
watch=False,
watch=watch,
cli_args=parse_args(args),
auth_token=_resolve_token(token, token_password),
base_url=base_url,
Expand Down
1 change: 1 addition & 0 deletions marimo/_messaging/ops.py
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ class UpdateCellCodes(Op):
name: ClassVar[str] = "update-cell-codes"
cell_ids: List[CellId_t]
codes: List[str]
code_is_stale: bool


@dataclass
Expand Down
6 changes: 6 additions & 0 deletions marimo/_server/api/endpoints/files.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ async def rename_file(
from_consumer_id=ConsumerId(app_state.require_current_session_id()),
)

if new_path:
# Handle rename for watch
app_state.session_manager.handle_file_rename_for_watch(
app_state.require_current_session_id(), new_path
)

return SuccessResponse()


Expand Down
9 changes: 0 additions & 9 deletions marimo/_server/api/lifespans.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,6 @@ async def lsp(app: Starlette) -> AsyncIterator[None]:
yield


@contextlib.asynccontextmanager
async def watcher(app: Starlette) -> AsyncIterator[None]:
state = AppState.from_app(app)
if state.watch:
session_mgr = state.session_manager
session_mgr.start_file_watcher()
yield


@contextlib.asynccontextmanager
async def open_browser(app: Starlette) -> AsyncIterator[None]:
state = AppState.from_app(app)
Expand Down
Loading
Loading