Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: always add marimo in sandbox #3439

Merged
merged 2 commits into from
Jan 15, 2025
Merged

improve: always add marimo in sandbox #3439

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb81134
improve: always add marimo in sandbox
akshayka Jan 14, 2025
0820428
run less frequently, only on manager creation
akshayka Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions marimo/_runtime/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,12 @@ def _update_runtime_from_user_config(self, config: MarimoConfig) -> None:
):
self.package_manager = create_package_manager(package_manager)

if self._should_update_script_metadata():
# All marimo notebooks depend on the marimo package; if the
# notebook already has an optional dependency group with marimo,
# such as marimo[sql], this is a NOOP.
self._update_script_metadata(["marimo"])

if (
autoreload_mode == "lazy" or autoreload_mode == "autorun"
# Pyodide doesn't support hot module reloading
Expand Down
Loading