fix: conversion of ipynb files with multiple definitions #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeTransformer wasn't visiting node descendants, leading to incomplete transformations.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mscolnick
approved these changes
Jan 16, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.14-dev22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NameTransformerwasn't visiting node descendants, leading to incomplete transformations.Before, when remapping
xto a local:was yielding
With this change, it now yields
This change also modifies an old test that was testing that the
NameTransformerrespected scoping logic. But it never actually did, or rather only did so because of a bug in which it wasn't visiting entire subtrees. Nothing relies on theNameTransformerrespecting scoping in our codebase.