Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3441 - Primitive get_sample_values #3467

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 16, 2025

Fix issue #3441 by ensuring get_sample_values returns only serializable primitives while preserving datetime objects.

Changes:

  • Modified unwrap_py_scalar to preserve datetime objects
  • Convert enum/categorical types to strings
  • Added test to verify primitive type conversion

Link to Devin run: https://app.devin.ai/sessions/e909db8e616a4a19a85737438b5e9575

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:55am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:55am

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@mscolnick mscolnick force-pushed the devin/1737053469-fix-enum-sample branch from b6c83a6 to 295e024 Compare January 17, 2025 00:52
@mscolnick mscolnick merged commit 11be99f into main Jan 17, 2025
34 checks passed
@mscolnick mscolnick deleted the devin/1737053469-fix-enum-sample branch January 17, 2025 01:37
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.14-dev28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant