Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hotkeys): add configurable completion selection movement #3475

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

metaboulie
Copy link
Contributor

📝 Summary

make keymaps introduced in #3382 configurable

Bildschirmfoto 2025-01-17 um 07 57 00

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

- Add completion.moveUp/Down hotkeys for navigating completion
suggestions
 - Make completion selection movement configurable in hotkeys menu
 - Update documentation with new hotkey options
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:07am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 0:07am

Copy link

vercel bot commented Jan 17, 2025

@metaboulie is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mscolnick mscolnick merged commit 8b6b6d3 into marimo-team:main Jan 17, 2025
20 checks passed
@metaboulie metaboulie deleted the eugene/keymap branch January 17, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants