Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: optimize workflow timeouts based on timing analysis #3481

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Optimize GitHub Actions Workflow Timeouts

This PR optimizes workflow timeouts based on analysis of recent workflow runs to prevent consuming unnecessary minutes while maintaining sufficient buffers.

Changes

playwright.yml

  • Reduced timeout from 16min to 13min
  • Analysis:
    • Max runtime: 7.0 minutes
    • Average runtime: 5.0 minutes
    • New timeout provides 85% buffer

test_cli.yaml

  1. build_wheel job:

    • Reduced timeout from 10min to 3min
    • Analysis:
      • Max runtime: ~1 minute
      • New timeout provides 200% buffer
  2. test_cli job:

    • Reduced timeout from 15min to 10min
    • Analysis:
      • Max runtime: 4.5 minutes (Windows)
      • Other platforms: ~1.5 minutes
      • New timeout provides 122% buffer
  3. test_examples job:

    • Reduced timeout from 15min to 3min
    • Analysis:
      • Max runtime: ~0.5 minutes
      • New timeout provides 500% buffer
      • Note: Job has continue-on-error enabled

Testing & Analysis

Changes are based on analysis of recent successful workflow runs using the GitHub API. All new timeouts maintain more than the requested 50-75% buffer over maximum observed runtimes to ensure reliability while preventing unnecessary resource consumption.

Link to Devin run: https://app.devin.ai/sessions/e653e561a2e648a581431a0a457d2ec6

- playwright.yml: reduce timeout from 16min to 13min (85% buffer)
- test_cli.yaml:
  - build_wheel: reduce from 10min to 3min (200% buffer)
  - test_cli: reduce from 15min to 10min (122% buffer)
  - test_examples: reduce from 15min to 3min (500% buffer)

Changes based on analysis of recent workflow runs to prevent
consuming unnecessary minutes while maintaining sufficient buffers.

Co-Authored-By: Myles Scolnick <myles@marimo.io>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 5:14pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 5:14pm

Update comment format to show average and max run times with date stamp
instead of showing what the timeout was reduced from.

Co-Authored-By: Myles Scolnick <myles@marimo.io>
Copy link
Contributor Author

CI Failure Investigation

I've investigated the failing test and determined it's unrelated to the workflow timeout changes in this PR.

Failed Test Details

  • Test: streams.spec.ts > 'stdout, stderr redirected to browser'
  • Location: frontend/e2e-tests/streams.spec.ts:17
  • Error: Timed out 5000ms waiting for expect(locator).toBeVisible()
    • Specifically waiting for text 'Hello, stderr!' to appear

Why This Is Unrelated

  1. The failure is a test-level timeout (5000ms) for element visibility
  2. Our PR only modified GitHub Actions workflow-level timeouts (in minutes)
  3. We did not modify any test code or test timeouts
  4. The test appears to be flaky, failing when stderr output doesn't appear within its 5-second expectation

Test Results Context

  • 32 tests passed
  • 8 tests skipped
  • 1 test failed (the one mentioned above)
  • Total test duration: 2.1 minutes

This appears to be a pre-existing flaky test issue where the stderr output occasionally doesn't appear within the expected timeframe. Our workflow timeout changes don't affect these internal test timeouts.

@mscolnick mscolnick merged commit bde19c6 into main Jan 17, 2025
21 of 23 checks passed
@mscolnick mscolnick deleted the devin/1737133584-optimize-workflow-timeouts branch January 17, 2025 17:25
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.14-dev30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant