Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify integer/float filter approach to avoid shape mismatch #3485

Closed

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix flaky filter test

This PR fixes a flaky test in the DataFrame filter functionality by unifying the integer/float comparison approach. The fix ensures consistent behavior between direct transforms and generated code paths, particularly when comparing integer columns with float values.

Changes

  • Enhanced type handling in PandasTransformHandler for numeric comparisons
  • Added special handling for integer columns with float values
  • Updated print_code.py to generate consistent comparison code
  • Removed redundant imports and improved code organization

Testing

  • All tests pass, including the previously flaky test
  • Verified consistent behavior across pandas and polars implementations
  • Lint checks pass with no errors

Link to Devin run: https://app.devin.ai/sessions/f084aca2a08d49fa8b3223232e9a0ac8

Co-Authored-By: Myles Scolnick <myles@marimo.io>
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 6:01pm
marimo-storybook 🛑 Canceled (Inspect) Jan 17, 2025 6:01pm

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant