Ensure return code non-zero on cli error #3499
Merged
+7
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After inspection, only the
shell_completion
did not use click methods to report errors. Fixed and added/updated tests for both internally detected errors.📝 Summary
Fixes #3476
🔍 Description of Changes
After code inspection, only the
shell_completion
did not use click methods to report errors. Fixed and added/updated tests for both internally detected errors.📋 Checklist
📜 Reviewers
@mscolnick