New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marko 4 support #3

Open

abiyasa wants to merge 3 commits into marko-js-samples:master from abiyasa:marko-4-support

Contributor

abiyasa commented Oct 2, 2017 •

edited

Loading

I upgrade the example to Marko 4. There are some big changes:

Change async-fragments to await
Remove the JS location support. On Marko 4, we don't have explicit <init-widgets/> anymore?
Use lasso-marko, marko/express, and marko/node-require.
No more w-bind. I created a stateful component <clickable-banner>. As a bonus, this component also display click counter to show that the state from server is still working.

There is a problem though:

When I run the Progressive in-order (with attribute client-reorder=false), the banners are NOT clickable until all of them rendered completely. This was not the case on Marko 3. Did I do something wrong? I also notice that we don't need to add await-renderer @patrick-steele-idem @austinkelleher

abiyasa added 3 commits

October 2, 2017 16:07


          Upgrade to marko 4 & use lasso-marko

e52a1fc


          Upgrade iframe page, create separated component

d88a876


          Improve rendering the click counter

144c40f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet