Enhanced Lock Request Handling with TTL Consideration #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is not authorized to perform: dynamodb:DeleteItem on resource: ... because no identity-based policy allows the dynamodb:DeleteItem action DeleteItem is also required
Update README.md - add DeleteItem
- **TTL Consideration**: Updated the lock request logic to consider the TTL (Time-To-Live) attribute when determining lock availability. Previously, TTL was ignored during lock requests, relying solely on DynamoDB's eventual purge, which can occur at any time, typically within a few days of expiration. Now, the lock request process checks the TTL to ensure that locks are not granted if the TTL has not yet expired. - **Testing Enhancements**: Added comprehensive tests to verify TTL expiration behavior and ensure locks are correctly released after TTL expiry. This includes simulating process crashes and verifying lock reacquisition. - **Documentation Update**: Updated `README.md` to reflect changes in TTL handling, clarifying that TTL is automatically managed and no manual configuration is needed for the TTL attribute. - **Code Refactoring**: Refactored code to improve readability and maintainability, including better logging and error handling. - Added `go test` wrapper script (`run-tests.sh`) for easier local testing
Enhanced Lock Request Handling with TTL Consideration
Release for v0.6.0
* Add lock/release info log to ensure the user is always informed about lock status. * Include detailed information in lock failure logs, showing TTL, expiration, and revision to avoid manual investigation. * Introduce a simple CLI-based test in run-tests.sh to demonstrate logging changes during local testing.
Enhance CLI tool logging
Release for v0.6.1
logging update, linter update
Release for v0.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.mdto reflect changes in TTL handling, clarifying that TTL is automatically managed and no manual configuration is needed for the TTL attribute.go testwrapper script (run-tests.sh) for easier local testingFixes #166
Full disclosure - I needed a release of this, so my fork has this released as 0.6.0 - I'm not married to this, but the changelog .....is wrong.