-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): adds info about connection types #50
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request updates the README.md file with comprehensive documentation about Tailscale subnet router connections. The new content focuses on explaining two primary connection types: Direct (peer-to-peer) and Relayed connections. The documentation provides insights into connection characteristics, potential stability issues, and includes a practical HCL configuration example for optimizing direct connections. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
77-93
: Consider adding more context about connection stability issues.While the example is helpful, consider adding:
- Frequency of these issues (e.g., rare, common)
- Specific conditions that might trigger them
- Whether this affects all database connections or specific scenarios
94-147
: Consider adding security recommendations.The configuration example is comprehensive, but consider adding:
- A note about the security implications of opening UDP port 41641 to 0.0.0.0/0
- Guidance on restricting the CIDR range if possible
- Best practices for securing direct connections in production environments
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🔇 Additional comments (1)
README.md (1)
70-76
: Well-structured introduction to connection types!The section provides clear and concise explanations of Tailscale's connection types, with helpful references to official documentation.
what
why
references
Summary by CodeRabbit