Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include stack specific before_init even if tfvars disabled + adds initial tests 🎉 #13

Merged
merged 7 commits into from
Dec 19, 2024
Merged

fix: include stack specific before_init even if tfvars disabled + adds initial tests 🎉 #13

merged 7 commits into from
Dec 19, 2024

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Dec 19, 2024 •
edited
Loading

what

  • Adds a bunch of tests! ⚡ ⚡ ⚡
  • Includes a fix around not including the stack specific before_init scripts IF tfvars.enabled was false

Warp 2024-12-18 21 52 42

why

  • Tests are AWESOME and we need em as we build out this root module more 💯
  • I found the small bug due to writing tests 🔥

references

  • N/A

@Gowiem Gowiem self-assigned this Dec 19, 2024
@Gowiem Gowiem requested a review from a team as a code owner December 19, 2024 02:56
gberenice
gberenice approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool! Great start towards awesome testing, thanks @Gowiem 🙌

@gberenice gberenice merged commit 9eb3cd4 into main Dec 19, 2024
2 checks passed
@gberenice gberenice deleted the chore/add-tofu-tests branch December 19, 2024 10:51
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
gberenice pushed a commit that referenced this pull request Dec 19, 2024
@github-actions
chore(main): release 0.3.1 (#15)
34d6023 
🤖 I have created a release *beep* *boop*
---


##
[0.3.1](v0.3.0...v0.3.1)
(2024-12-19)


### Bug Fixes

* check if tfvars file exists only if when it's expected
([#16](#16))
([72c5a77](72c5a77))
* include stack specific `before_init` even if tfvars disabled + adds
initial tests 🎉
([#13](#13))
([9eb3cd4](9eb3cd4))
* pass github_enterprise.id to stacks
([#14](#14))
([f4c6c1b](f4c6c1b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

Assignees

@Gowiem Gowiem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gowiem @gberenice