Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds a TF testing workflow + changes renovate schedule #18

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Dec 22, 2024

what

  • Adds a tf-test workflow for running terraform + tofu tests

why

  • This will ensure we're always running tests on each PR to make sure we don't break anything

references

  • N/A

@Gowiem Gowiem self-assigned this Dec 22, 2024
@Gowiem Gowiem requested a review from a team as a code owner December 22, 2024 16:23
@Gowiem Gowiem force-pushed the chore/add-test-pipeline branch from 92aa3f1 to d1df464 Compare December 22, 2024 16:29
oycyc
oycyc previously approved these changes Dec 22, 2024
Copy link
Contributor

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!! This automation module's potential is so much.


- name: Aqua Install
shell: bash
run: aqua install --tags terraform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reading through this, I was wondering if we should use GitHub Action with the matrix strategy to make it more DRY: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#using-a-matrix-strategy

We could replace any usage of terraform or tofu with something like ${{ matrix.tooling }}.

But also at the same time, we're just maintaining these two so it doesn't really matter to make it super optimized.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this out!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working and I like it 👍 We can break it up in the future if terraform + tofu decide to diverge in some way that makes this difficult

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@Gowiem Gowiem force-pushed the chore/add-test-pipeline branch from f309302 to 0be6f97 Compare December 22, 2024 20:44
@Gowiem Gowiem enabled auto-merge (squash) December 22, 2024 20:48
@Gowiem Gowiem requested a review from oycyc December 22, 2024 21:04
@Gowiem Gowiem changed the title chore: adds a TF testing workflow chore: adds a TF testing workflow + changes renovate schedule Dec 22, 2024
Copy link
Contributor

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matrix is nice

@Gowiem Gowiem merged commit 1cee9dc into main Dec 22, 2024
4 checks passed
@Gowiem Gowiem deleted the chore/add-test-pipeline branch December 22, 2024 23:13
@spacelift-masterpointio
Copy link

spacelift-masterpointio bot commented Dec 23, 2024

⚠️Spacelift Stack Failure⚠️

@Gowiem - This pull request was deployed and the following Spacelift stack failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants