-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds a TF testing workflow + changes renovate schedule #18
Conversation
92aa3f1
to
d1df464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! This automation module's potential is so much.
.github/workflows/tf-test.yaml
Outdated
|
||
- name: Aqua Install | ||
shell: bash | ||
run: aqua install --tags terraform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reading through this, I was wondering if we should use GitHub Action with the matrix strategy to make it more DRY: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#using-a-matrix-strategy
We could replace any usage of terraform
or tofu
with something like ${{ matrix.tooling }}.
But also at the same time, we're just maintaining these two so it doesn't really matter to make it super optimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working and I like it 👍 We can break it up in the future if terraform + tofu decide to diverge in some way that makes this difficult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
f309302
to
0be6f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matrix is nice
|
what
why
references