Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign to reduce boilerplate code. Reorganize files #9

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Conversation

mat-kie
Copy link
Owner

@mat-kie mat-kie commented Dec 8, 2024

Changes

  • remove separate structs for model and controller components. use trait based approach instead
  • reorganize folder structure to reflect said changes

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 70.46632% with 228 lines in your changes missing coverage. Please review.

Project coverage is 66.11%. Comparing base (966a321) to head (00a261e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/components/bluetooth.rs 58.78% 122 Missing ⚠️
src/components/application.rs 82.74% 34 Missing ⚠️
src/view/acquisition.rs 0.00% 27 Missing ⚠️
src/view/overview.rs 0.00% 13 Missing ⚠️
src/components/measurement.rs 92.75% 10 Missing ⚠️
src/components/storage.rs 88.76% 10 Missing ⚠️
src/view/manager.rs 0.00% 5 Missing ⚠️
src/model/bluetooth.rs 0.00% 4 Missing ⚠️
src/main.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   60.54%   66.11%   +5.56%     
==========================================
  Files          12       11       -1     
  Lines        1280     1260      -20     
==========================================
+ Hits          775      833      +58     
+ Misses        505      427      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mat-kie mat-kie merged commit bc29a9a into main Dec 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants