develop #1125
Open
develop #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineuito
commented
Jan 14, 2025
nineuito
commented
- DEMO LINK
added 2 commits
January 14, 2025 19:22
volodymyr-soltys97
suggested changes
Jan 15, 2025
src/modules/Game.class.js
Outdated
Comment on lines
51
to
74
| const prevState = structuredClone(this.state); | ||
|
|
||
| for (let i = 0; i < 4; i++) { | ||
| const row = this.state[i].filter((cell) => cell !== 0); | ||
|
|
||
| for (let j = row.length - 1; j > 0; j--) { | ||
| if (row[j] === row[j - 1]) { | ||
| row[j] *= 2; | ||
| this.score += row[j]; | ||
| row.splice(j - 1, 1); | ||
| j--; | ||
| } | ||
| } | ||
|
|
||
| while (row.length < 4) { | ||
| row.unshift(0); | ||
| } | ||
| this.state[i] = row; | ||
| } | ||
|
|
||
| if (prevState !== structuredClone(this.state)) { | ||
| this.addRandomTile(); | ||
| this.updateGameStatus(); | ||
| } |
There was a problem hiding this comment.
This logic is similar in every method, try to put it in a helper function and use it everywhere
…n the game class with handleMove
etojeDenys
suggested changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.