Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #1132

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Develop #1132

wants to merge 6 commits into from

Conversation

olhakostovetska
Copy link

etojeDenys
etojeDenys suggested changes Jan 18, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restart button doesn't work, try to fix it
image

volodymyr-soltys97
volodymyr-soltys97 suggested changes Jan 19, 2025
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Add a favicon on the page
image

src/modules/Game.class.js Outdated

const prevState = JSON.stringify(this.grid);

// Переміщаємо клітинки вправо без об'єднання
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all comments

src/scripts/main.js Outdated
}

switch (event.key) {
case 'ArrowLeft':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create variables for event keys

anastasiiavorobiova
anastasiiavorobiova suggested changes Jan 19, 2025
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Consider fixing the restart button. A user should be able to restart the game

vadiimvooo
vadiimvooo approved these changes Jan 19, 2025
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadiimvooo vadiimvooo vadiimvooo approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olhakostovetska @volodymyr-soltys97 @etojeDenys @vadiimvooo @anastasiiavorobiova