initial commit #2739
Open
initial commit #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaura333
approved these changes
Nov 8, 2023
src/convertToObject.js
Outdated
| return fixedKey; | ||
| }); | ||
|
|
||
| // console.log(array); |
There was a problem hiding this comment.
We can get rid of unnecessary comments
src/convertToObject.js
Outdated
Comment on lines
19
to
40
| let array = sourceString.split(';'); | ||
|
|
||
| if (array.length === 0) { | ||
| return {}; | ||
| } | ||
|
|
||
| // let's remove unnecesary signs here (clearing array) | ||
| array = array.map((key) => { | ||
| return key.replace(/\n/g, '').trim(); | ||
| }).filter(Boolean); | ||
|
|
||
| // creating key:value pairs in array | ||
| array = array.map((key) => { | ||
| return key.split(':'); | ||
| }); | ||
|
|
||
| // cleaning inside, this time triming each element | ||
| array = array.map((key) => { | ||
| const fixedKey = key.map((el) => el.trim()); | ||
|
|
||
| return fixedKey; | ||
| }); |
There was a problem hiding this comment.
Instead of overwriting array, you could try to implement chaining of array methods
src/convertToObject.js
Outdated
Comment on lines
31
to
40
| array = array.map((key) => { | ||
| return key.split(':'); | ||
| }); | ||
|
|
||
| // cleaning inside, this time triming each element | ||
| array = array.map((key) => { | ||
| const fixedKey = key.map((el) => el.trim()); | ||
|
|
||
| return fixedKey; | ||
| }); |
There was a problem hiding this comment.
E.g. here you could use two methods on key ( .split(...).map(...) ) while mapping the whole array only one time
mvjl000
suggested changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.