Solution #3376
Solution #3376
Conversation
src/convertToObject.js
Outdated
| // write your code here | ||
| const stylesObject = {}; | ||
|
|
||
| const declarations = sourceString |
There was a problem hiding this comment.
The variable name 'declarations' could be more descriptive. Consider renaming it to something that indicates it contains CSS declarations.
src/convertToObject.js
Outdated
| const stylesObject = {}; | ||
|
|
||
| const declarations = sourceString | ||
| .split(/;(?![^(]*\))/) |
There was a problem hiding this comment.
The regular expression used in split might not handle all edge cases, such as when there are semicolons within strings or comments in the CSS. Consider refining it to handle these cases.
src/convertToObject.js
Outdated
| .filter((decl) => decl); | ||
|
|
||
| declarations.forEach((declaration) => { | ||
| const [property, ...valueParts] = declaration.split(':'); |
There was a problem hiding this comment.
The 'split' operation assumes that there will be only one ':' character separating property and value. If the value contains additional ':' characters (e.g., in a data URI), this could lead to incorrect results.
src/convertToObject.js
Outdated
| const [property, ...valueParts] = declaration.split(':'); | ||
| const value = valueParts.join(':').trim(); | ||
|
|
||
| if (property && value) { |
There was a problem hiding this comment.
Checking if 'property' and 'value' are truthy is good, but consider also checking that 'property' is not an empty string after trimming.
src/convertToObject.js
Outdated
| const stringWithoutComments = sourceString.replace( | ||
| /\/\*[^*]*\*+([^/*][^*]*\*+)*\//g, | ||
| '', | ||
| ); | ||
|
|
||
| const matches = stringWithoutComments.match(/(?:[^;"']|"[^"]*"|'[^']*')+/g); | ||
| const cssDeclarations = matches | ||
| ? matches.map((decl) => decl.trim()).filter((decl) => decl) | ||
| : []; |
There was a problem hiding this comment.
You don't need regular expressions for this task. Just split the string ; remove spaces, and empty lines.
src/convertToObject.js
Outdated
| cssDeclarations.forEach((declaration) => { | ||
| const [property, ...valueParts] = declaration.split(':'); |
There was a problem hiding this comment.
- You can use
reduceto generate an object const [key, value] = declaration.split(':');After the first steps your string should looks likecolor: red;, so you can just split and remove spaces then
No description provided.