-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #3790
base: master
Are you sure you want to change the base?
Solution #3790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the convertToObject
function! 🎉 Your code meets all the task requirements and constraints, effectively converting CSS style strings into objects. The use of split
and reduce
is spot on, and you've handled edge cases like empty style declarations well. Keep up the excellent work and continue honing your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -6,7 +6,19 @@ | |||
* @return {object} | |||
*/ | |||
function convertToObject(sourceString) { | |||
// write your code here | |||
const styles = sourceString.split(';'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code correctly splits the source string into style declarations using semicolons.
return styles.reduce((prev, item) => { | ||
if (item.trim()) { | ||
let [key, val] = item.split(':'); | ||
|
||
key = key.trim(); | ||
val = val.trim(); | ||
prev[key] = val; | ||
} | ||
|
||
return prev; | ||
}, {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reduce function processes each style declaration. However, it is important to note that the task does not require handling cases with multiple semicolons without any styles between them. The current implementation already handles this by checking if item.trim()
is truthy before processing it, which is correct.
No description provided.