Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #3845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

solution #3845

wants to merge 1 commit into from

Conversation

st74eet
Copy link

@st74eet st74eet commented Jan 20, 2025

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on implementing the convertToObject function! 🎉 Your solution meets the task requirements and handles the style string parsing effectively. While there's a minor issue with the reduce function needing to always return the accumulator, it doesn't impact the overall functionality. Keep up the good work, and consider refining variable names for better readability in the future. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +20 to +21
if (parts.length !== 2) {
return;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reduce function should always return the accumulator (prev). If parts.length !== 2, you should return prev instead of undefined to ensure the reduction process continues correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants