completed jv-array-list #1208
Open
completed jv-array-list #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivan95kos
suggested changes
Nov 1, 2023
| public class ArrayList<T> implements List<T> { | ||
|
|
||
| private static final int DEFAULT_CAPACITY = 10; | ||
| private Object[] elements; |
There was a problem hiding this comment.
use the parameterized type
Suggested change
| private Object[] elements; | |
| private T [] elements; |
| public class ArrayList<T> implements List<T> { | ||
|
|
Comment on lines
48
to
50
| if (index < 0 || index >= size) { | ||
| throw new ArrayListIndexOutOfBoundsException("Index is out of bounds"); | ||
| } |
There was a problem hiding this comment.
move it to a private method checkIndex(int index)
you use this check three times
Suggested change
| if (index < 0 || index >= size) { | |
| throw new ArrayListIndexOutOfBoundsException("Index is out of bounds"); | |
| } | |
| if (index < 0 || index >= size) { | |
| throw new ArrayListIndexOutOfBoundsException("Index is out of bounds: " + index); | |
| } |
|
|
||
| private int indexOf(T element) { | ||
| for (int i = 0; i < size; i++) { | ||
| if (Objects.equals(elements[i], element)) { |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may not have been able to adhere to all the "Try to avoid these common mistakes while solving task", but the task was not easy. I hope for your help if you find any mistakes