Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArrayList.java #1513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 64 additions & 5 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,107 @@
package core.basesyntax;

import java.util.NoSuchElementException;

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_SIZE = 10;
private static final double GROW_MULTIPLIER = 1.5;
private int size;
private Object[] elementData;

public ArrayList() {
elementData = new Object[DEFAULT_SIZE];

}

public void checkCapacity() {
if (size == elementData.length) {
int newSize = (int)(elementData.length * GROW_MULTIPLIER);
Object[] newArray = new Object[newSize];
System.arraycopy(elementData, 0, newArray, 0, size);
elementData = newArray;
}
}

@Override
public void add(T value) {
checkCapacity();
elementData[size++] = value;

}

@Override
public void add(T value, int index) {
checkIndexForSet(index);
checkCapacity();
System.arraycopy(elementData, index, elementData, index + 1, size - index);
elementData[index] = value;
size++;

}

public void checkIndexForSet(int index) {
if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", Size: " + size);
Comment on lines +43 to +44

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ArrayListIndexOutOfBoundsException class is not defined in the provided files. You need to implement this custom exception to handle invalid index cases as required by the task description.

}
}
Comment on lines +42 to +46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method checkIndexForSet is redundant since it performs similar logic to the checkIndex method. Consider using a single method for index validation to avoid code repetition, as suggested in the checklist: "If the logic of your code repeats - move it to a separate private method."


@Override
public void addAll(List<T> list) {
for (int i = 0; i < list.size(); i++) {
add(list.get(i));

}

}

@Override
public T get(int index) {
return null;
checkIndex(index);
return (T) elementData[index];

}

public void checkIndex(int index) {
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", Size: " + size);
}
}

@Override
public void set(T value, int index) {
checkIndex(index);
elementData[index] = value;

}

@Override
public T remove(int index) {
return null;
checkIndex(index);
T removedValue = (T) elementData[index];
System.arraycopy(elementData, index + 1, elementData, index, size - index - 1);
elementData[--size] = null;
return removedValue;
}

@Override
public T remove(T element) {
return null;
for (int i = 0; i < size; i++) {
if ((element == null && elementData[i] == null)
|| (element != null && element.equals(elementData[i]))) {
return remove(i);
}

}
throw new NoSuchElementException("This element doesn't exist in Array :" + element);
}

@Override
public int size() {
return 0;
return size;
}

@Override
public boolean isEmpty() {
return false;
return size() == 0;
}
}
Loading