Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 62 additions & 9 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,101 @@
package core.basesyntax;

import java.util.NoSuchElementException;

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_CAPACITY = 10;
private static final double GROW_INDEX = 1.5;
private T[] elementData;
private int size;

public ArrayList() {
this.elementData = (T[]) new Object[DEFAULT_CAPACITY];
}

@Override
public void add(T value) {

if (size == elementData.length) {
grow();
}
elementData[size++] = value;
}

@Override
public void add(T value, int index) {

checkIndexForAdd(index);
if (size == elementData.length) {
grow();
}
System.arraycopy(elementData, index, elementData, index + 1, size - index);
elementData[index] = value;
size++;
}

@Override
public void addAll(List<T> list) {

for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}
}
Comment on lines 35 to 39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a check for null or empty lists in the addAll(List<T> list) method to avoid unnecessary operations.


@Override
public T get(int index) {
return null;
checkIndex(index);
return elementData[index];
}

@Override
public void set(T value, int index) {

checkIndex(index);
elementData[index] = value;
}

@Override
public T remove(int index) {
return null;
checkIndex(index);
T deleteValue = elementData[index];
System.arraycopy(elementData, index + 1, elementData, index, size - index - 1);
elementData[--size] = null;
return deleteValue;
}

@Override
public T remove(T element) {
return null;
for (int i = 0; i < size; i++) {
if (elementData[i] == null && element == null
|| elementData[i] != null && elementData[i].equals(element)) {
Comment on lines +65 to +66

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using == to compare objects is incorrect for non-primitive types. Use equals() to compare the elementData[i] with element to ensure proper object comparison.

return remove(i);
}
}
throw new NoSuchElementException("Element not found");
}

@Override
public int size() {
return 0;
return size;
}

@Override
public boolean isEmpty() {
return false;
return size == 0;
}

private void checkIndex(int index) {
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", is invalid");
}
}

private void checkIndexForAdd(int index) {
if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException("Index: " + index + ", is invalid");
}
}

private void grow() {
int newCapacity = (int) (elementData.length * GROW_INDEX);
T[] newElementData = (T[]) new Object[newCapacity];
System.arraycopy(elementData, 0, newElementData, 0, size);
elementData = newElementData;
}
}
Loading