make ArrayList class #1547

MykolaTurak · 2025-01-06T13:27:30Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this implementation! 😊 There are a couple of critical issues that need to be addressed before we can approve this pull request:

Custom Exception Definition: The ArrayListIndexOutOfBoundsException is used in your code, but it hasn't been defined in the provided files. This will lead to compilation errors. Please ensure that this exception class is implemented, or consider using a standard exception like IndexOutOfBoundsException if a custom exception is not necessary.
Code Duplication: The index checks in methods like add(T value, int index), get(int index), set(T value, int index), and remove(int index) are repeated. Moving this logic to a separate private method will help adhere to the DRY (Don't Repeat Yourself) principle and improve code maintainability.

Once these issues are resolved, your code will be in great shape! Keep up the great work, and don't hesitate to reach out if you need any help. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2025-01-06T13:28:41Z

src/main/java/core/basesyntax/ArrayList.java

+        if (index > size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't add object");


The custom exception ArrayListIndexOutOfBoundsException is used here, but it is not defined in the provided files. Ensure that this exception class is implemented, or replace it with a standard exception if custom exceptions are not required.

mateacademy-ai-mentor · 2025-01-06T13:28:42Z

src/main/java/core/basesyntax/ArrayList.java

+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't get object");


The custom exception ArrayListIndexOutOfBoundsException is used here, but it is not defined in the provided files. Ensure that this exception class is implemented, or replace it with a standard exception if custom exceptions are not required.

mateacademy-ai-mentor · 2025-01-06T13:28:42Z

src/main/java/core/basesyntax/ArrayList.java

+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't set object");


The custom exception ArrayListIndexOutOfBoundsException is used here, but it is not defined in the provided files. Ensure that this exception class is implemented, or replace it with a standard exception if custom exceptions are not required.

mateacademy-ai-mentor · 2025-01-06T13:28:42Z

src/main/java/core/basesyntax/ArrayList.java

+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't remove object");


The custom exception ArrayListIndexOutOfBoundsException is used here, but it is not defined in the provided files. Ensure that this exception class is implemented, or replace it with a standard exception if custom exceptions are not required.

mateacademy-ai-mentor · 2025-01-06T13:28:42Z

src/main/java/core/basesyntax/ArrayList.java

+        if (index > size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't add object");
+        }
+        if (size == dataStorage.length) {
+            grow();
+        }
+        System.arraycopy(dataStorage, index, dataStorage, index + 1, size - index);
+        dataStorage[index] = value;
+        size++;
    }

    @Override
    public void addAll(List<T> list) {
-
+        for (int i = 0; i < list.size(); i++) {
+            this.add(list.get(i));
+        }
    }

    @Override
    public T get(int index) {
-        return null;
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't get object");
+        }
+        return (T) this.dataStorage[index];
    }

    @Override
    public void set(T value, int index) {
-
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't set object");
+        }
+        this.dataStorage[index] = value;
    }

    @Override
    public T remove(int index) {
-        return null;
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't remove object");
+        }


The index checks in the methods add(T value, int index), get(int index), set(T value, int index), and remove(int index) are repeated. According to the checklist, you should move this logic to a separate private method to avoid code duplication and adhere to the DRY principle.

mateacademy-ai-mentor

Great job on implementing the ArrayList class! 🎉 While your code is mostly correct, there are a couple of critical issues that need attention:

Custom Exception Definition: The ArrayListIndexOutOfBoundsException is referenced but not defined in your files, which will lead to compilation errors. Please ensure this exception class is implemented, or consider using the standard IndexOutOfBoundsException if a custom exception isn't necessary.
Code Duplication: The index checks in methods like add(T value, int index), get(int index), set(T value, int index), and remove(int index) are repeated. Extracting this logic into a private method will help you adhere to the DRY (Don't Repeat Yourself) principle and improve code maintainability.

These issues are important for the functionality and maintainability of your code, so please address them in future iterations. Keep up the great work, and use this feedback to enhance your coding skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2025-01-06T13:33:32Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public void add(T value, int index) {
-
+        if (index > size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't add object");


The ArrayListIndexOutOfBoundsException is not defined in the provided files. This will cause a compilation error. Consider defining this exception class or using IndexOutOfBoundsException.

mateacademy-ai-mentor · 2025-01-06T13:33:32Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public T get(int index) {
-        return null;
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't get object");


The ArrayListIndexOutOfBoundsException is not defined in the provided files. This will cause a compilation error. Consider defining this exception class or using IndexOutOfBoundsException.

mateacademy-ai-mentor · 2025-01-06T13:33:32Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public void set(T value, int index) {
-
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't set object");


The ArrayListIndexOutOfBoundsException is not defined in the provided files. This will cause a compilation error. Consider defining this exception class or using IndexOutOfBoundsException.

mateacademy-ai-mentor · 2025-01-06T13:33:33Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public T remove(int index) {
-        return null;
+        if (index >= size || index < 0) {
+            throw new ArrayListIndexOutOfBoundsException("Can't remove object");


The ArrayListIndexOutOfBoundsException is not defined in the provided files. This will cause a compilation error. Consider defining this exception class or using IndexOutOfBoundsException.

mateacademy-ai-mentor · 2025-01-06T13:33:33Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public void add(T value, int index) {
-
+        if (index > size || index < 0) {


Consider extracting the index check logic into a private method to avoid code duplication and adhere to the DRY principle.

mateacademy-ai-mentor · 2025-01-06T13:33:33Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public T get(int index) {
-        return null;
+        if (index >= size || index < 0) {


Consider extracting the index check logic into a private method to avoid code duplication and adhere to the DRY principle.

mateacademy-ai-mentor · 2025-01-06T13:33:33Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public void set(T value, int index) {
-
+        if (index >= size || index < 0) {


Consider extracting the index check logic into a private method to avoid code duplication and adhere to the DRY principle.

mateacademy-ai-mentor · 2025-01-06T13:33:33Z

src/main/java/core/basesyntax/ArrayList.java

    }

    @Override
    public T remove(int index) {
-        return null;
+        if (index >= size || index < 0) {


Consider extracting the index check logic into a private method to avoid code duplication and adhere to the DRY principle.

make ArrayList class

3191eb7

mateacademy-ai-mentor suggested changes Jan 6, 2025

View reviewed changes

solve style problems

1406ddd

MykolaTurak requested a review from mateacademy-ai-mentor January 6, 2025 13:31

mateacademy-ai-mentor approved these changes Jan 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make ArrayList class #1547

make ArrayList class #1547

MykolaTurak commented Jan 6, 2025

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

mateacademy-ai-mentor Jan 6, 2025

		if (index > size \|\| index < 0) {
		throw new ArrayListIndexOutOfBoundsException("Can't add object");

		if (index >= size \|\| index < 0) {
		throw new ArrayListIndexOutOfBoundsException("Can't get object");

make ArrayList class #1547

Are you sure you want to change the base?

make ArrayList class #1547

Conversation

MykolaTurak commented Jan 6, 2025

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment