-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
done #1557
base: master
Are you sure you want to change the base?
done #1557
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,48 +1,113 @@ | ||||||||||
package core.basesyntax; | ||||||||||
|
||||||||||
import java.util.Arrays; | ||||||||||
import java.util.NoSuchElementException; | ||||||||||
|
||||||||||
public class ArrayList<T> implements List<T> { | ||||||||||
private Object[] elements; | ||||||||||
private int size; | ||||||||||
|
||||||||||
public ArrayList() { | ||||||||||
elements = new Object[10]; | ||||||||||
size = 0; | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. int type = 0 by default
Suggested change
|
||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void add(T value) { | ||||||||||
|
||||||||||
ifFullResize(); | ||||||||||
elements[size++] = value; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void add(T value, int index) { | ||||||||||
|
||||||||||
validateIndexForAdd(index); | ||||||||||
ifFullResize(); | ||||||||||
if (index >= 0 && index <= size) { | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The index check |
||||||||||
for (int i = size; i > index; i--) { | ||||||||||
elements[i] = elements[i - 1]; | ||||||||||
} | ||||||||||
elements[index] = value; | ||||||||||
size++; | ||||||||||
} | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void addAll(List<T> list) { | ||||||||||
|
||||||||||
for (int i = 0; i < list.size(); i++) { | ||||||||||
add(list.get(i)); | ||||||||||
} | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public T get(int index) { | ||||||||||
return null; | ||||||||||
validateIndex(index); | ||||||||||
return (T) elements[index]; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void set(T value, int index) { | ||||||||||
|
||||||||||
validateIndex(index); | ||||||||||
elements[index] = value; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public T remove(int index) { | ||||||||||
return null; | ||||||||||
validateIndex(index); | ||||||||||
ifFullResize(); | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The call to |
||||||||||
T removedElement = (T) elements[index]; | ||||||||||
for (int i = index; i < size - 1; i++) { | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||||||||||
elements[i] = elements[i + 1]; | ||||||||||
} | ||||||||||
size--; | ||||||||||
return removedElement; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public T remove(T element) { | ||||||||||
return null; | ||||||||||
for (int i = 0; i < size; i++) { | ||||||||||
if (elements[i] != null && elements[i].equals(element) | ||||||||||
|| elements[i] == null && element == null) { | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
return remove(i); | ||||||||||
} | ||||||||||
} | ||||||||||
throw new NoSuchElementException("Element not found in the list"); | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public int size() { | ||||||||||
return 0; | ||||||||||
return size; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public boolean isEmpty() { | ||||||||||
return false; | ||||||||||
return size == 0; | ||||||||||
} | ||||||||||
|
||||||||||
private void ifFullResize() { | ||||||||||
if (size == elements.length) { | ||||||||||
resize(); | ||||||||||
} | ||||||||||
} | ||||||||||
|
||||||||||
private void resize() { | ||||||||||
elements = Arrays.copyOf(elements, elements.length + (elements.length / 2)); | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
} | ||||||||||
|
||||||||||
private void validateIndex(int index) { | ||||||||||
if (index < 0 || index >= size) { | ||||||||||
throw new ArrayListIndexOutOfBoundsException("Index " | ||||||||||
+ index | ||||||||||
+ " is out of bounds for size " | ||||||||||
+ size); | ||||||||||
} | ||||||||||
} | ||||||||||
|
||||||||||
private void validateIndexForAdd(int index) { | ||||||||||
if (index < 0 || index > size) { | ||||||||||
throw new ArrayListIndexOutOfBoundsException("Index " | ||||||||||
+ index | ||||||||||
+ " is out of bounds for size " | ||||||||||
+ size); | ||||||||||
} | ||||||||||
} | ||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 is a magic number, create constant