-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_home_work_advanced_oop #1781
base: master
Are you sure you want to change the base?
add_home_work_advanced_oop #1781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! While your implementation is mostly correct, there are a few critical issues that need to be addressed before we can approve the pull request:
-
Interface Naming: The interface
Drowable
is misspelled and should be corrected toDrawable
. This is important for maintaining clarity and consistency in your codebase. -
Enum Constant Access: Throughout your code, ensure that you use the
name()
method to access enum constants (e.g.,Figures.Circle.name()
). This prevents potential issues iftoString()
is overridden in the enum class. -
Redundant Code: In the
Square
class, the call tothis.setColor(color);
is redundant because the superclass constructor already sets the color. Removing unnecessary code helps keep your implementation clean and efficient.
These changes are essential to ensure that your code functions as expected and adheres to the task requirements. Once you've made these adjustments, feel free to resubmit your pull request. Keep up the great work, and don't hesitate to reach out if you have any questions or need further assistance! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 🎉 Your implementation is mostly correct, but there are a few critical issues that need attention:
-
Interface Naming: The interface
Drowable
is misspelled and should be corrected toDrawable
to maintain clarity and consistency in your codebase. -
Enum Constant Access: In the
draw()
methods of theRectangle
,Circle
,RightTriangle
,Square
, andIsoscelesTrapezoid
classes, consider usingFigures.<Enum>.name()
instead of directly accessing the enum constants. This ensures consistency and avoids potential issues iftoString()
is overridden. -
Redundant Code: In the
Square
class, the call tothis.setColor(color);
is redundant because the superclass constructor already sets the color. Consider removing this line to avoid unnecessary code. -
Measurement Units: Ensure that linear measurements like
radius
,side
,firstLeg
,secondLeg
,width
,height
,baseTop
, andbaseBottom
are not labeled as 'sq. units'. They should be labeled as 'units' since they are linear measurements, not areas.
These changes are essential to ensure that your code functions as expected and adheres to the task requirements. The decision to approve is made to help you move forward with your learning. Please review the comments and improve your code accordingly. Keep up the great work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
***homeWork : advanced-oop
result output