Figure #1784

IgorArsionov · 2025-01-14T19:14:01Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this pull request! 😊 While you've made a solid effort, there are a few critical issues that need to be addressed before we can approve it:

Use of super for Fields: Directly setting fields like color, name, and area in subclasses using super is not ideal. It's better to initialize these fields using a constructor in the Figure class.
Magic Numbers: The code contains magic numbers, such as 5 in new Figure[5]. Consider defining constants for these values to improve readability and maintainability.
Constructor Expressions: Avoid passing expressions directly into constructors. Assign random values to variables first for better readability.
Typos in Output Strings: There are typos in the output strings, such as 'sq. until' instead of 'sq. units'. Please correct these to ensure clarity.
Code Cleanliness: Remove or uncomment any unnecessary lines to keep the code clean and maintainable.

Addressing these issues will not only improve the functionality and readability of your code but also align it with best practices. Keep up the great work, and I'm confident you'll nail it with these adjustments! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2025-01-14T19:17:19Z

src/main/java/core/basesyntax/Circle.java

+public class Circle extends Figure {
+    int radius;
+    public Circle(int radius, String color) {
+        super.color = color;


Directly accessing and modifying the color field of the superclass using super is not a good practice. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:19Z

src/main/java/core/basesyntax/Circle.java

+    public Circle(int radius, String color) {
+        super.color = color;
+        this.radius = radius;
+        super.name = "Circle";


Directly setting the name field of the superclass using super is not ideal. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:19Z

src/main/java/core/basesyntax/Circle.java

+        super.color = color;
+        this.radius = radius;
+        super.name = "Circle";
+        super.area = Math.PI * radius * radius;


Directly setting the area field of the superclass using super is not ideal. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:19Z

src/main/java/core/basesyntax/FigureSupplier.java

+        ColorSupplier supplier = new ColorSupplier();
+        Random random = new Random();
+
+        Figure[] figure = new Figure[5];


Consider defining a constant for the number of figures (5) to avoid using magic numbers. This will improve code readability and maintainability.

mateacademy-ai-mentor · 2025-01-14T19:17:19Z

src/main/java/core/basesyntax/FigureSupplier.java

+        Random random = new Random();
+
+        Figure[] figure = new Figure[5];
+        figure[0] = new Square(random.nextInt(10) + 1, supplier.getRandomColor());


Avoid passing expressions directly into the constructor. Assign the random value to a variable first for better code readability.

mateacademy-ai-mentor · 2025-01-14T19:17:21Z

src/main/java/core/basesyntax/RightTriangle.java

+
+    @Override
+    public String getFigure() {
+        return "Figure: " + super.name + ", area: " + super.area + " sq. until, firstLeg: " + firstLeg + " until, secondLeg: " + secondLeg + " until, color: " + super.color;


There are typos in the output string: 'sq. until' should be 'sq. units', and 'until' should be 'units'.

mateacademy-ai-mentor · 2025-01-14T19:17:21Z

src/main/java/core/basesyntax/Square.java

+    double firstSide;
+    public Square(int firstSide, String color){
+        this.firstSide = firstSide;
+        super.color = color;


Directly accessing and modifying the color field of the superclass using super is not a good practice. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:21Z

src/main/java/core/basesyntax/Square.java

+    public Square(int firstSide, String color){
+        this.firstSide = firstSide;
+        super.color = color;
+        super.name = "Square";


Directly setting the name field of the superclass using super is not ideal. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:21Z

src/main/java/core/basesyntax/Square.java

+        this.firstSide = firstSide;
+        super.color = color;
+        super.name = "Square";
+        super.area = firstSide * firstSide;


Directly setting the area field of the superclass using super is not ideal. Consider using a constructor in the Figure class to initialize this field.

mateacademy-ai-mentor · 2025-01-14T19:17:22Z

src/main/java/core/basesyntax/Square.java

+
+    @Override
+    public String getFigure() {
+        return "Figure: " + super.name + ", area: " + super.area + " sq. until, side: " + firstSide + " until, color: " + super.color;


There are typos in the output string: 'sq. until' should be 'sq. units', and 'until' should be 'units'.

mateacademy-ai-mentor

Great job on making significant improvements to your code! 🎉 While there are still a few issues to address, such as the use of super for field initialization and the presence of magic numbers, your efforts to enhance readability and consistency are evident.

Here are some key points to focus on for further refinement:

Field Initialization: Avoid using super to set fields like color, area, and name directly in subclasses. Instead, consider initializing these fields in the Figure class constructor to maintain a clean and consistent design.
Type Consistency: Ensure that constructor parameters match the field types to avoid unnecessary casting. For example, using double for parameters like firstSide, secondSide, firstLeg, secondLeg, and height can help maintain consistency.
Magic Numbers: Replace magic numbers, such as 5 and 6, with named constants to improve code readability and maintainability.
Enum Usage: Consider using the Color enum directly instead of String for color-related methods to maintain consistency and leverage the benefits of type safety.

Your dedication to improving your code is commendable. Keep up the great work, and continue to learn from these experiences to enhance your coding skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2025-01-14T19:54:27Z

src/main/java/core/basesyntax/Circle.java

+public class Circle extends Figure {
+    int radius;
+    public Circle(int radius, String color) {
+        super(color, Math.PI * radius * radius,"Circle");


Using super to set fields like color, area, and name directly is not ideal. Consider initializing these fields in the Figure class constructor instead.

mateacademy-ai-mentor · 2025-01-14T19:54:27Z

src/main/java/core/basesyntax/ColorSupplier.java

+
+public class ColorSupplier {
+
+    public String getRandomColor() {


Consider changing the return type of getRandomColor() to Color instead of String to maintain consistency with the Color enum.

mateacademy-ai-mentor · 2025-01-14T19:54:27Z

src/main/java/core/basesyntax/ColorSupplier.java

+        return color[random.nextInt(color.length)].name();
+    }
+
+    public String getDefaultColor() {


Consider changing the return type of getDefaultColor() to Color instead of String to maintain consistency with the Color enum.

mateacademy-ai-mentor · 2025-01-14T19:54:27Z

src/main/java/core/basesyntax/FigureSupplier.java

+        figure[2] = new Rectangle(value1[2], value1[2] + 10, colors[2]);
+        figure[3] = new RightTriangle(value1[3], value1[3], colors[3]);
+        figure[4] = new IsoscelesTrapezoid(value1[4], value1[4] + 6, value1[0], colors[4]);
+        return figure[random.nextInt(5)];


Replace the magic number 5 with NUMBER_OF_FIGURES to maintain consistency and improve readability.

mateacademy-ai-mentor · 2025-01-14T19:54:28Z

src/main/java/core/basesyntax/FigureSupplier.java

+
+    public Figure getDefaultFigure() {
+        ColorSupplier supplier = new ColorSupplier();
+        String color = supplier.getDefaultColor();


Consider using the Color enum directly instead of String for color consistency.

mateacademy-ai-mentor · 2025-01-14T19:54:29Z

src/main/java/core/basesyntax/Rectangle.java

+    double firstSide;
+    double secondSide;
+
+    public Rectangle(int firstSide, int secondSide, String color) {


Consider using double for the constructor parameters firstSide and secondSide to match the field types and avoid unnecessary casting.

mateacademy-ai-mentor · 2025-01-14T19:54:29Z

src/main/java/core/basesyntax/RightTriangle.java

+    double secondLeg;
+
+    public RightTriangle(int firstLeg, int secondLeg, String color) {
+        super(color, (double) (firstLeg * secondLeg) / 2, "RightTriangle");


Using super to set fields like color, area, and name directly is not ideal. Consider initializing these fields in the Figure class constructor instead.

mateacademy-ai-mentor · 2025-01-14T19:54:29Z

src/main/java/core/basesyntax/RightTriangle.java

+    double firstLeg;
+    double secondLeg;
+
+    public RightTriangle(int firstLeg, int secondLeg, String color) {


Consider using double for the constructor parameters firstLeg and secondLeg to match the field types and avoid unnecessary casting.

mateacademy-ai-mentor · 2025-01-14T19:54:30Z

src/main/java/core/basesyntax/Square.java

+public class Square extends Figure{
+    double firstSide;
+    public Square(int firstSide, String color){
+        super(color, firstSide * firstSide, "Square");


Using super to set fields like color, area, and name directly is not ideal. Consider initializing these fields in the Figure class constructor instead.

mateacademy-ai-mentor · 2025-01-14T19:54:30Z

src/main/java/core/basesyntax/Square.java

+
+public class Square extends Figure{
+    double firstSide;
+    public Square(int firstSide, String color){


Consider using double for the constructor parameter firstSide to match the field type and avoid unnecessary casting.

First

257036a

mateacademy-ai-mentor suggested changes Jan 14, 2025

View reviewed changes

IgorArsionov added 2 commits January 14, 2025 21:47

update

c94b631

update

5c241b6

IgorArsionov requested a review from mateacademy-ai-mentor January 14, 2025 19:51

mateacademy-ai-mentor approved these changes Jan 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Figure #1784

Figure #1784

IgorArsionov commented Jan 14, 2025

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025

mateacademy-ai-mentor Jan 14, 2025


		public class ColorSupplier {

		public String getRandomColor() {

Figure #1784

Are you sure you want to change the base?

Figure #1784

Conversation

IgorArsionov commented Jan 14, 2025

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment