-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hw 14 jv stream practice #1197
base: main
Are you sure you want to change the base?
Hw 14 jv stream practice #1197
Changes from 11 commits
b8a7b0a
654abcc
fd6eeec
6bb1f00
83541d9
af4df4a
ec1ccbb
411a5b8
0b0b983
b9fcb25
cf897a5
99799ed
8a2fd27
3c6e87c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,23 @@ | ||
package practice; | ||
|
||
public class CandidateValidator { | ||
//write your code here | ||
import java.util.function.Predicate; | ||
import model.Candidate; | ||
|
||
public class CandidateValidator implements Predicate<Candidate> { | ||
private static final String NATIONALITY = "Ukrainian"; | ||
private static final Integer MIN_AGE = 35; | ||
private static final Integer MIN_PERIOD = 10; | ||
|
||
@Override | ||
public boolean test(Candidate candidate) { | ||
String[] years = candidate.getPeriodsInUkr().split("-"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. better make separator constant field |
||
int fromYear = Integer.parseInt(years[0]); | ||
int toYear = Integer.parseInt(years[1]); | ||
Comment on lines
+15
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider adding error handling for |
||
int period = toYear - fromYear; | ||
|
||
return candidate.getAge() >= MIN_AGE | ||
&& candidate.isAllowedToVote() | ||
&& candidate.getNationality().equals(NATIONALITY) | ||
&& period >= MIN_PERIOD; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,80 +1,69 @@ | ||||||
package practice; | ||||||
|
||||||
import java.util.Collections; | ||||||
import java.util.Arrays; | ||||||
import java.util.List; | ||||||
import java.util.NoSuchElementException; | ||||||
import java.util.stream.Collectors; | ||||||
import java.util.stream.IntStream; | ||||||
import model.Candidate; | ||||||
import model.Cat; | ||||||
import model.Person; | ||||||
|
||||||
public class StreamPractice { | ||||||
/** | ||||||
* Given list of strings where each element contains 1+ numbers: | ||||||
* input = {"5,30,100", "0,22,7", ...} | ||||||
* return min integer value. One more thing - we're interested in even numbers. | ||||||
* If there is no needed data throw RuntimeException with message | ||||||
* "Can't get min value from list: < Here is our input 'numbers' >" | ||||||
*/ | ||||||
public int findMinEvenNumber(List<String> numbers) { | ||||||
return 0; | ||||||
return numbers.stream() | ||||||
.map(s -> s.split(",")) | ||||||
.flatMap(Arrays::stream) | ||||||
.map(Integer::parseInt) | ||||||
.filter(n -> n % 2 == 0) | ||||||
.sorted() | ||||||
.findFirst() | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can replace it using |
||||||
.orElseThrow(() -> new RuntimeException("Can't get min value from list: " | ||||||
+ numbers)); | ||||||
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The use of |
||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of Integer numbers, | ||||||
* return the average of all odd numbers from the list or throw NoSuchElementException. | ||||||
* But before that subtract 1 from each element on an odd position (having the odd index). | ||||||
*/ | ||||||
public Double getOddNumsAverage(List<Integer> numbers) { | ||||||
return 0D; | ||||||
return IntStream.range(0, numbers.size()) | ||||||
.map(i -> (i % 2 != 0) ? numbers.get(i) - 1 : numbers.get(i)) | ||||||
Comment on lines
+25
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic for adjusting numbers at odd indices by subtracting 1 is not immediately clear. Ensure this logic is intentional and documented, as it may confuse future maintainers. |
||||||
.filter(n -> n % 2 != 0) | ||||||
.average() | ||||||
.orElseThrow(() -> new NoSuchElementException("Unable " | ||||||
+ "to get average odd number from: " + numbers)); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||||||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||||||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||||||
* select from the List only men whose age is from `fromAge` to `toAge` inclusively. | ||||||
* <p> | ||||||
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||||||
*/ | ||||||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getSex() == Person.Sex.MAN | ||||||
&& p.getAge() >= fromAge | ||||||
&& p.getAge() <= toAge) | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Let’s fix it everywhere |
||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||||||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||||||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||||||
* select from the List only people whose age is from `fromAge` and to `maleToAge` (for men) | ||||||
* or to `femaleToAge` (for women) inclusively. | ||||||
* <p> | ||||||
* Example: select people of working age | ||||||
* (from 18 y.o. and to 60 y.o. for men and to 55 y.o. for women inclusively). | ||||||
*/ | ||||||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||||||
int maleToAge, List<Person> peopleList) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getAge() >= fromAge | ||||||
&& p.getAge() <= (p.getSex() == Person.Sex.MAN | ||||||
? maleToAge | ||||||
: femaleToAge)) | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of `Person` instances (having `name`, `age`, `sex` and `cats` fields, | ||||||
* and each `Cat` having a `name` and `age`), | ||||||
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||||||
*/ | ||||||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getSex() == Person.Sex.WOMAN && p.getAge() >= femaleAge) | ||||||
.flatMap(p -> p.getCats().stream()) | ||||||
.map(Cat::getName) | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Your help with a election is needed. Given list of candidates, where each element | ||||||
* has Candidate.class type. | ||||||
* Check which candidates are eligible to apply for president position and return their | ||||||
* names sorted alphabetically. | ||||||
* The requirements are: person should be older than 35 years, should be allowed to vote, | ||||||
* have nationality - 'Ukrainian' | ||||||
* and live in Ukraine for 10 years. For the last requirement use field periodsInUkr, | ||||||
* which has following view: "2002-2015" | ||||||
* We want to reuse our validation in future, so let's write our own impl of Predicate | ||||||
* parametrized with Candidate in CandidateValidator. | ||||||
*/ | ||||||
public List<String> validateCandidates(List<Candidate> candidates) { | ||||||
return Collections.emptyList(); | ||||||
CandidateValidator validator = new CandidateValidator(); | ||||||
|
||||||
return candidates.stream() | ||||||
.filter(validator) | ||||||
.map(Candidate::getName) | ||||||
.sorted() | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the
getPeriodsInUkr()
method in theCandidate
class returns a valid string in the format 'YYYY-YYYY'. If the format is incorrect,ArrayIndexOutOfBoundsException
orNumberFormatException
might occur.