Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of all methods from tasks and class CandidateValidator #1202

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
@Override
public boolean test(Candidate candidate) {
if (candidate == null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just use

Suggested change
if (candidate == null) {
return candidate.getAge() >= MIN_AGE
&& candidate.isAllowedToVote()
&& candidate.getNationality().equals(REQUIRED_NATIONALITY)
&& checkTimeLivingInCountry(candidate);

create separate method to checkTimeLivingInCountry()

return false;
}

boolean oldEnough = candidate.getAge() >= 35;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's create constants for age and nationality, 1 and 0 and "-"

boolean nationality = candidate.getNationality().equals("Ukrainian");
boolean canVote = candidate.isAllowedToVote();
String[] ages = candidate.getPeriodsInUkr().split("-");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create constant for "-"

boolean liveEnoughInUkraine = Integer.parseInt(ages[1])
- Integer.parseInt(ages[0]) >= 10;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the getPeriodsInUkr() method returns a valid string that can be split into two parts representing the start and end years. Consider adding error handling for cases where parsing might fail, such as when the string is not in the expected format or contains non-numeric values.


return oldEnough && nationality && canVote && liveEnoughInUkraine;
}
}
46 changes: 39 additions & 7 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
Expand All @@ -14,7 +18,13 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()
.flatMap(s -> Arrays.stream(s.split(",")))
.map(Integer::parseInt)
Comment on lines +21 to +22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding error handling for the Integer.parseInt operation. If the input string contains non-numeric values or is not in the expected format, this will throw a NumberFormatException. Adding a try-catch block or validating the input format before parsing could prevent runtime errors.

.filter(n -> n % 2 == 0)
.min(Integer::compareTo)
.orElseThrow(() -> new RuntimeException("Can't get min value from list: "
+ numbers));
}

/**
Expand All @@ -23,7 +33,12 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
return IntStream.range(0, numbers.size())
.mapToObj(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i))
.filter(n -> n % 2 != 0)
.mapToDouble(n -> n)
.average()
.orElseThrow(() -> new NoSuchElementException("Can't find any odd numbers"));
}

/**
Expand All @@ -35,7 +50,10 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(m -> m.getSex() == Person.Sex.MAN)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for other places

Suggested change
.filter(m -> m.getSex() == Person.Sex.MAN)
.filter(person -> person.getSex() == Person.Sex.MAN)

.filter(m -> m.getAge() >= fromAge && m.getAge() <= toAge)
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for other places

Suggested change
.collect(Collectors.toList());
.toList();

}

/**
Expand All @@ -50,7 +68,12 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> (p.getSex() == Person.Sex.MAN && p.getAge() >= fromAge

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename p

&& p.getAge() <= maleToAge)
|| (p.getSex() == Person.Sex.WOMAN && p.getAge() >= fromAge
&& p.getAge() <= femaleToAge))
.collect(Collectors.toList());
}

/**
Expand All @@ -59,7 +82,11 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(w -> w.getSex() == Person.Sex.WOMAN && w.getAge() >= femaleAge)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename w
this is a person list, so use person for example

.flatMap(w -> w.getCats().stream())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the getCats() method returns a non-null list to avoid potential NullPointerException. You might want to add a null check or use Optional to handle cases where a person might not have any cats.

.map(Cat::getName)
.collect(Collectors.toList());
}

/**
Expand All @@ -75,6 +102,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
CandidateValidator candidateValidator = new CandidateValidator();
return candidates.stream()
.filter(candidateValidator)
.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());
}
}
Loading