-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hw jv stream #1204
base: main
Are you sure you want to change the base?
Hw jv stream #1204
Changes from 4 commits
9cdf373
8721295
1af7254
e8acf45
e74cf45
8a68811
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,36 @@ | ||
package practice; | ||
|
||
public class CandidateValidator { | ||
import java.util.Arrays; | ||
import java.util.function.Predicate; | ||
import model.Candidate; | ||
|
||
public class CandidateValidator implements Predicate<Candidate> { | ||
|
||
@Override | ||
public boolean test(Candidate candidate) { | ||
if (candidate.getAge() < 35) { | ||
return false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can refactor your code like
|
||
} | ||
|
||
if (!candidate.isAllowedToVote()) { | ||
return false; | ||
} | ||
|
||
if (!"Ukrainian".equals(candidate.getNationality())) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make nationality constant field |
||
return false; | ||
} | ||
|
||
String[] periods = candidate.getPeriodsInUkr().split(","); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make separator constant field |
||
int totalYearInUkraine = Arrays.stream(periods) | ||
.mapToInt(period -> { | ||
String[] range = period.trim().split("-"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the same |
||
int startYear = Integer.parseInt(range[0]); | ||
int endYear = Integer.parseInt(range[1]); | ||
return endYear - startYear + 1; // Учитываем включение последнего года | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove comment |
||
}) | ||
.sum(); | ||
|
||
return totalYearInUkraine >= 10; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make 10 a constant field with an informative name |
||
} | ||
//write your code here | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,8 +1,12 @@ | ||||||
package practice; | ||||||
|
||||||
import java.util.Collections; | ||||||
import java.util.Arrays; | ||||||
import java.util.List; | ||||||
import java.util.NoSuchElementException; | ||||||
import java.util.stream.Collectors; | ||||||
import java.util.stream.IntStream; | ||||||
import model.Candidate; | ||||||
import model.Cat; | ||||||
import model.Person; | ||||||
|
||||||
public class StreamPractice { | ||||||
|
@@ -14,7 +18,13 @@ public class StreamPractice { | |||||
* "Can't get min value from list: < Here is our input 'numbers' >" | ||||||
*/ | ||||||
public int findMinEvenNumber(List<String> numbers) { | ||||||
return 0; | ||||||
return numbers.stream() | ||||||
.flatMap(str -> Arrays.stream(str.split(","))) | ||||||
.map(Integer::parseInt) | ||||||
.filter(num -> num % 2 == 0) | ||||||
.min(Integer::compareTo) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
It’s default behavior |
||||||
.orElseThrow(() -> | ||||||
new RuntimeException("Can't get min value from list " + numbers)); | ||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -23,7 +33,11 @@ public int findMinEvenNumber(List<String> numbers) { | |||||
* But before that subtract 1 from each element on an odd position (having the odd index). | ||||||
*/ | ||||||
public Double getOddNumsAverage(List<Integer> numbers) { | ||||||
return 0D; | ||||||
return IntStream.range(0, numbers.size()) | ||||||
.map(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i)) | ||||||
.filter(i -> i % 2 == 1) | ||||||
.average() | ||||||
.orElseThrow(NoSuchElementException::new); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let’s provide an informative message |
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -35,7 +49,10 @@ public Double getOddNumsAverage(List<Integer> numbers) { | |||||
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||||||
*/ | ||||||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getSex().equals(Person.Sex.MAN) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename p |
||||||
&& (p.getAge() >= fromAge && p.getAge() <= toAge)) | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -50,7 +67,12 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA | |||||
*/ | ||||||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||||||
int maleToAge, List<Person> peopleList) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> (p.getSex().equals(Person.Sex.MAN) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename p |
||||||
&& p.getAge() >= fromAge && p.getAge() <= maleToAge) | ||||||
|| p.getSex().equals(Person.Sex.WOMAN) | ||||||
&& p.getAge() >= fromAge && p.getAge() <= femaleToAge) | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -59,7 +81,11 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | |||||
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||||||
*/ | ||||||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename p |
||||||
.flatMap(person -> person.getCats().stream()) | ||||||
.map(Cat::getName) | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -75,6 +101,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | |||||
* parametrized with Candidate in CandidateValidator. | ||||||
*/ | ||||||
public List<String> validateCandidates(List<Candidate> candidates) { | ||||||
return Collections.emptyList(); | ||||||
CandidateValidator candidateValidator = new CandidateValidator(); | ||||||
return candidates.stream() | ||||||
.filter(candidateValidator) | ||||||
.map(Candidate::getName) | ||||||
.sorted() | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create constants for 35 and other magic numbers |
also for comma and numbers