first #1207

YarikNarozhnyi01 · 2024-12-21T20:35:04Z

No description provided.

mateacademy-ai-mentor

Thank you for your hard work on this pull request! 🚀 While your code is mostly on the right track, there are a few critical issues that need to be addressed before we can proceed:

Exception Handling: There are multiple instances where Integer.parseInt is used without proper error handling. This can lead to NumberFormatException if the input strings are not valid integers. It's important to add error handling to ensure the robustness of your code.
Null Safety: Ensure that methods like getCats() return non-null lists to avoid potential NullPointerException. Consider using Optional or adding null checks where necessary.
Unused Variables: The variable sum is declared but not used in the method. Removing unused variables can help clean up the code and improve readability.
String Format Validation: Ensure that candidate.getPeriodsInUkr() returns a string in the expected format. If the format is not guaranteed, additional validation or error handling might be necessary to avoid runtime exceptions.

Addressing these issues will significantly improve the functionality and reliability of your code. Once these changes are made, we can move forward with the approval process. Keep up the great work, and don't hesitate to reach out if you have any questions! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2024-12-21T20:35:49Z

src/main/java/practice/CandidateValidator.java

+        String[] splitted = candidate.getPeriodsInUkr().split("-");
+        int inted = Integer.parseInt(splitted[1]) - Integer.parseInt(splitted[0]);


Consider adding error handling for Integer.parseInt to prevent potential NumberFormatException if the split method does not return valid integers. This can happen if the getPeriodsInUkr method returns a malformed string.

mateacademy-ai-mentor · 2024-12-21T20:35:49Z

src/main/java/practice/CandidateValidator.java

+        if (candidate.isAllowedToVote() && candidate.getAge() >= 35 && candidate.getNationality().equals("Ukrainian")
+        && inted >= 10) {


Ensure that candidate.getPeriodsInUkr() returns a string in the expected format. If the format is not guaranteed, additional validation or error handling might be necessary to avoid runtime exceptions.

mateacademy-ai-mentor · 2024-12-21T20:35:49Z

src/main/java/practice/StreamPractice.java

+        return numbers.stream()
+                .map(s -> s.split(","))
+                .flatMap(strings -> Arrays.stream(strings))
+                .map(s -> Integer.parseInt(s))


Consider adding error handling for Integer.parseInt to prevent potential NumberFormatException if the input strings are not valid integers.

mateacademy-ai-mentor · 2024-12-21T20:35:49Z

src/main/java/practice/StreamPractice.java

@@ -23,7 +36,12 @@
     * But before that subtract 1 from each element on an odd position (having the odd index).
     */
    public Double getOddNumsAverage(List<Integer> numbers) {
-        return 0D;
+        Double sum = (double) 0;


The variable sum is declared but not used in the method. It can be removed to clean up the code.

mateacademy-ai-mentor · 2024-12-21T20:35:49Z

src/main/java/practice/StreamPractice.java

@@ -59,7 +82,12 @@
     * return the names of all cats whose owners are women from `femaleAge` years old inclusively.
     */
    public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
-        return Collections.emptyList();
+         return peopleList.stream()
+                .filter(s -> s.getAge() >= femaleAge && !s.getCats().isEmpty() && s.getSex() == Person.Sex.WOMAN)


Ensure that getCats() returns a non-null list to avoid potential NullPointerException. Consider using Optional or adding a null check if necessary.

mateacademy-ai-mentor

Great job on implementing the CandidateValidator and StreamPractice classes! 🎉 While the code is generally well-structured, there are a few critical issues that need attention to enhance its robustness and reliability:

Exception Handling:
- In the findMinEvenNumber method, ensure the error message in the RuntimeException includes the actual input list numbers for better context.
- Consider adding error handling for Integer.parseInt to prevent NumberFormatException if the input string is not a valid integer. A try-catch block can be helpful here.
Code Cleanliness:
- The variable sum in the getOddNumsAverage method is declared but not used. Removing it will clean up the code.
String Format Validation:
- Ensure that candidate.getPeriodsInUkr() returns a string in the expected format (e.g., 'YYYY-YYYY'). If the format is not guaranteed, consider adding validation or error handling to avoid runtime exceptions.
Use of Constants:
- In CandidateValidator, replace magic numbers and strings with constants for better readability and maintainability.
Null Safety:
- Ensure the getCats() method returns a non-null list to avoid potential NullPointerException. Consider adding null checks or using Optional.

These changes are necessary to ensure the code meets the specified requirements and constraints. The decision to approve is made to help you move forward with your learning. Please review the comments and address these issues to improve your code. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-12-21T22:24:29Z

src/main/java/practice/CandidateValidator.java

+public class CandidateValidator implements Predicate<Candidate> {
+    @Override
+    public boolean test(Candidate candidate) {
+        String[] splitted = candidate.getPeriodsInUkr().split("-");


Consider adding error handling for Integer.parseInt to prevent NumberFormatException if the input string is not a valid integer. You can use a try-catch block to handle this exception.

mateacademy-ai-mentor · 2024-12-21T22:24:29Z

src/main/java/practice/CandidateValidator.java

+public class CandidateValidator implements Predicate<Candidate> {
+    @Override
+    public boolean test(Candidate candidate) {
+        String[] splitted = candidate.getPeriodsInUkr().split("-");


Ensure that candidate.getPeriodsInUkr() returns a string in the expected format (e.g., 'YYYY-YYYY'). If the format is not guaranteed, consider adding validation or error handling to avoid runtime exceptions.

mateacademy-ai-mentor · 2024-12-21T22:24:29Z

src/main/java/practice/StreamPractice.java

+        return numbers.stream()
+                .map(s -> s.split(","))
+                .flatMap(strings -> Arrays.stream(strings))
+                .map(s -> Integer.parseInt(s))


Consider adding error handling for Integer.parseInt to prevent NumberFormatException if the input string is not a valid integer. You can use a try-catch block to handle this exception.

mateacademy-ai-mentor · 2024-12-21T22:24:29Z

src/main/java/practice/StreamPractice.java

+                        new RuntimeException("Can't get min value from list: "
+                                + "< Here is our input 'numbers' >"));


The error message in the RuntimeException should include the actual input list numbers to provide more context when the exception is thrown.

mateacademy-ai-mentor · 2024-12-21T22:24:30Z

src/main/java/practice/StreamPractice.java

@@ -23,7 +34,12 @@
     * But before that subtract 1 from each element on an odd position (having the odd index).
     */
    public Double getOddNumsAverage(List<Integer> numbers) {
-        return 0D;
+        Double sum = (double) 0;


The variable sum is declared but not used in the getOddNumsAverage method. Consider removing it to clean up the code.

okuzan · 2024-12-22T11:16:23Z

src/main/java/practice/StreamPractice.java

+                .map(s -> s.getCats())
+                .flatMap(s -> s.stream())
+                 .map(s -> s.getName())
+                .collect(Collectors.toList());


not a mistake,but use method references where possible, use .toList()

okuzan · 2024-12-22T11:16:40Z

src/main/java/practice/CandidateValidator.java

+        if (candidate.isAllowedToVote() && candidate.getAge() >= 35
+                && candidate.getNationality().equals("Ukrainian")
+                && inted >= 10) {
+            return true;


extract to constants

okuzan · 2024-12-22T11:16:50Z

src/main/java/practice/CandidateValidator.java

+    @Override
+    public boolean test(Candidate candidate) {
+        String[] splitted = candidate.getPeriodsInUkr().split("-");
+        int inted = Integer.parseInt(splitted[1]) - Integer.parseInt(splitted[0]);


indexes to constants too

okuzan · 2024-12-22T11:17:00Z

src/main/java/practice/StreamPractice.java

+                .filter(new CandidateValidator())
+                 .map(s -> s.getName())
+                 .sorted()
+                .collect(Collectors.toList());


Elena-Bruyako · 2024-12-22T18:03:59Z

src/main/java/practice/CandidateValidator.java

+import model.Candidate;
+
+public class CandidateValidator implements Predicate<Candidate> {
+    private static final String nationality = "Ukrainian";


let's check naming convention for constants

Elena-Bruyako · 2024-12-22T18:05:27Z

src/main/java/practice/CandidateValidator.java

+    @Override
+    public boolean test(Candidate candidate) {
+        String[] splitted = candidate.getPeriodsInUkr().split("-");
+        int inted = Integer.parseInt(splitted[partTwo]) - Integer.parseInt(splitted[partOne]);


what is it inted?

Elena-Bruyako · 2024-12-22T18:05:52Z

src/main/java/practice/StreamPractice.java

-        return 0;
+        return numbers.stream()
+                .map(s -> s.split(","))
+                .flatMap(strings -> Arrays.stream(strings))


let's combine map and flatMap

Elena-Bruyako · 2024-12-22T18:06:39Z

src/main/java/practice/StreamPractice.java

@@ -35,7 +50,10 @@ public Double getOddNumsAverage(List<Integer> numbers) {
     * Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
     */
    public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
-        return Collections.emptyList();
+        return peopleList.stream()
+                .filter(s -> s.getAge() >= fromAge && s.getAge() <= toAge


rename s

check other methods

Elena-Bruyako · 2024-12-22T18:07:09Z

src/main/java/practice/StreamPractice.java

+                .filter(s -> s.getAge() >= femaleAge && !s.getCats().isEmpty()
+                        && s.getSex() == Person.Sex.WOMAN)
+                .map(s -> s.getCats())
+                .flatMap(s -> s.stream())


combine map and flatMap

Elena-Bruyako · 2024-12-22T18:36:40Z

src/main/java/practice/StreamPractice.java

+                .map(s -> s.split(","))
+                .flatMap(strings -> Arrays.stream(strings))


Suggested change

.map(s -> s.split(","))

.flatMap(strings -> Arrays.stream(strings))

.flatMap(input -> Arrays.stream(input.split(",")))

Elena-Bruyako · 2024-12-22T18:37:13Z

src/main/java/practice/StreamPractice.java

+                .map(cat -> cat.getCats())
+                .flatMap(s -> s.stream())


Suggested change

.map(cat -> cat.getCats())

.flatMap(s -> s.stream())

.flatMap(person -> person.getCats().stream())

Elena-Bruyako · 2024-12-22T18:37:20Z

src/main/java/practice/StreamPractice.java

-        return Collections.emptyList();
+        return candidates.stream()
+                .filter(new CandidateValidator())
+                 .map(s -> s.getName())


Elena-Bruyako · 2024-12-22T18:37:59Z

src/main/java/practice/StreamPractice.java

+                .flatMap(strings -> Arrays.stream(strings))
+                .map(s -> Integer.parseInt(s))
+                .filter(s -> s % 2 == 0)
+                .min((s,b) -> s - b)


Suggested change

.min((s,b) -> s - b)

.min(Integer::compareTo)

liliia-ponomarenko

Good job! A few minor comments ;)

liliia-ponomarenko · 2024-12-23T09:44:29Z

src/main/java/practice/StreamPractice.java

@@ -23,7 +33,12 @@ public int findMinEvenNumber(List<String> numbers) {
     * But before that subtract 1 from each element on an odd position (having the odd index).
     */
    public Double getOddNumsAverage(List<Integer> numbers) {
-        return 0D;
+        Double sum = (double) 0;


remove unused variable

liliia-ponomarenko · 2024-12-23T09:45:06Z

src/main/java/practice/CandidateValidator.java

+
+    @Override
+    public boolean test(Candidate candidate) {
+        String[] splitted = candidate.getPeriodsInUkr().split("-");


the separator also should be constant

first

20f0aa7

mateacademy-ai-mentor suggested changes Dec 21, 2024

View reviewed changes

Yaroslav Narozhnyi added 2 commits December 22, 2024 00:13

fff

7b74c7a

fgf

c302217

YarikNarozhnyi01 requested a review from mateacademy-ai-mentor December 21, 2024 22:23

mateacademy-ai-mentor approved these changes Dec 21, 2024

View reviewed changes

YarikNarozhnyi01 requested a review from mateacademy-ai-mentor December 21, 2024 22:24

okuzan suggested changes Dec 22, 2024

View reviewed changes

Yaroslav Narozhnyi added 2 commits December 22, 2024 19:35

Check new

7c0c122

last_Check

a87b69d

YarikNarozhnyi01 requested a review from okuzan December 22, 2024 17:51

Elena-Bruyako suggested changes Dec 22, 2024

View reviewed changes

fff

746d792

YarikNarozhnyi01 requested a review from Elena-Bruyako December 22, 2024 18:33

Elena-Bruyako suggested changes Dec 22, 2024

View reviewed changes

maybe_final

e9fa9a2

YarikNarozhnyi01 requested a review from Elena-Bruyako December 23, 2024 09:21

liliia-ponomarenko approved these changes Dec 23, 2024

View reviewed changes

Change_in_code

f8c05cd

YarikNarozhnyi01 requested a review from liliia-ponomarenko December 23, 2024 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

first #1207

first #1207

YarikNarozhnyi01 commented Dec 21, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

mateacademy-ai-mentor Dec 21, 2024

okuzan Dec 22, 2024

okuzan Dec 22, 2024

okuzan Dec 22, 2024

okuzan Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

Elena-Bruyako Dec 22, 2024

liliia-ponomarenko left a comment

liliia-ponomarenko Dec 23, 2024

liliia-ponomarenko Dec 23, 2024

		String[] splitted = candidate.getPeriodsInUkr().split("-");
		int inted = Integer.parseInt(splitted[1]) - Integer.parseInt(splitted[0]);

		if (candidate.isAllowedToVote() && candidate.getAge() >= 35 && candidate.getNationality().equals("Ukrainian")
		&& inted >= 10) {

		new RuntimeException("Can't get min value from list: "
		+ "< Here is our input 'numbers' >"));

		.map(s -> s.split(","))
		.flatMap(strings -> Arrays.stream(strings))

	.map(s -> s.split(","))
	.flatMap(strings -> Arrays.stream(strings))
	.flatMap(input -> Arrays.stream(input.split(",")))

	.map(cat -> cat.getCats())
	.flatMap(s -> s.stream())
	.flatMap(person -> person.getCats().stream())

first #1207

Are you sure you want to change the base?

first #1207

Conversation

YarikNarozhnyi01 commented Dec 21, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liliia-ponomarenko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment