Methods with lambda are implemented #1209

SSXcorp · 2024-12-25T16:59:04Z

No description provided.

mateacademy-ai-mentor

Great job on implementing the task requirements effectively! 🎉 Your use of Java Streams and Predicate implementation is spot on. While there are a few areas for improvement, such as optimizing the getOddNumsAverage method with IntStream and ensuring exception messages match the task format, these are minor and don't impact the core functionality. Also, consider adding validation for the years list to enhance robustness. Keep up the excellent work and continue refining your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-12-25T16:59:50Z

src/main/java/practice/CandidateValidator.java

+        List<Integer> years = Arrays.stream(candidate.getPeriodsInUkr().split("-"))
+                .map(Integer::parseInt)
+                .collect(Collectors.toList());


Consider adding validation to ensure that the years list contains exactly two elements before accessing them. This will prevent potential IndexOutOfBoundsException if the getPeriodsInUkr method does not return a valid range.

mateacademy-ai-mentor · 2024-12-25T16:59:50Z

src/main/java/practice/StreamPractice.java

+                .orElseThrow(() -> new RuntimeException("Can't get min value from list: "
+                        + numbers));


Ensure that the exception message format matches the task requirement: "Can't get min value from list: " + numbers.

mateacademy-ai-mentor · 2024-12-25T16:59:50Z

src/main/java/practice/StreamPractice.java

+                .filter(n -> n % 2 != 0)
+                .mapToDouble(Double::valueOf)
+                .average()
+                .orElseThrow(() -> new NoSuchElementException("No odd numbers found"));


Consider using IntStream directly to filter odd numbers, which can simplify the logic and improve performance. This aligns with the checklist advice to use a single map operation where possible.

okuzan

Good job!

okuzan · 2024-12-25T20:26:09Z

src/main/java/practice/CandidateValidator.java

+        return candidate.getAge() >= MINIMAL_AGE
+                && candidate.isAllowedToVote()
+                && candidate.getNationality().equals(NATIONALITY)
+                && (years.get(1) - years.get(0)) >= MINIMAL_YEARS_IN_UA;


you can make indexes constants too

okuzan · 2024-12-25T20:28:03Z

src/main/java/practice/StreamPractice.java

+                .filter(VALIDATOR)
+                .map(Candidate::getName)
+                .sorted()
+                .collect(Collectors.toList());


Suggested change

.collect(Collectors.toList());

.toList();

it's very common, that's why the introduced .toList(), fix everywhere

Ok. The answer why I made code like this : On the Mate academy platform task it was impossible to use just toList() construction.

okuzan · 2024-12-25T20:28:30Z

src/main/java/practice/StreamPractice.java

+                    if (person.getSex() == Person.Sex.MAN) {
+                        return person.getAge() <= maleToAge;
+                    } else {
+                        return person.getAge() <= femaleToAge;
+                    }


use ternary operator to streamline this

- Constants in CandidateValidator class - Simplified collect to List method - Used ternary operator in getWorkablePeople method against if-else block

- Checkstyle fixes - simplified findMinEvenNumber stream

sarakhmen

let's slightly improve your solution :)

src/main/java/practice/CandidateValidator.java

src/main/java/practice/StreamPractice.java

- Coma and dash constants represented - changed getOddNumsAverage method impl

Sanderfuck · 2024-12-27T11:22:03Z

src/main/java/practice/StreamPractice.java

+                .mapToDouble(i -> {
+                    int value = numbers.get(i);
+                    return i % 2 != 0 ? value - 1 : value;
+                })
+                .filter(n -> n % 2 != 0.0)
+                .average()
+                .getAsDouble();


Suggested change

.mapToDouble(i -> {

int value = numbers.get(i);

return i % 2 != 0 ? value - 1 : value;

})

.filter(n -> n % 2 != 0.0)

.average()

.getAsDouble();

.map(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i))

.filter(n -> n % 2 == 1)

.average()

.orElseThrow();

SSXcorp added 2 commits December 25, 2024 18:57

Implemented methods with lambda

aa13615

Simplified CandidateValidator test() code

182765e

mateacademy-ai-mentor approved these changes Dec 25, 2024

View reviewed changes

okuzan suggested changes Dec 25, 2024

View reviewed changes

SSXcorp added 2 commits December 26, 2024 17:08

Fixed :

6c823b1

- Constants in CandidateValidator class - Simplified collect to List method - Used ternary operator in getWorkablePeople method against if-else block

Fixed :

fd9b0b5

- Checkstyle fixes - simplified findMinEvenNumber stream

SSXcorp requested a review from okuzan December 26, 2024 15:11

sarakhmen suggested changes Dec 26, 2024

View reviewed changes

src/main/java/practice/CandidateValidator.java Outdated Show resolved Hide resolved

src/main/java/practice/StreamPractice.java Outdated Show resolved Hide resolved

src/main/java/practice/StreamPractice.java Outdated Show resolved Hide resolved

Fixed :

e5d3975

- Coma and dash constants represented - changed getOddNumsAverage method impl

SSXcorp requested a review from sarakhmen December 27, 2024 08:05

Sanderfuck suggested changes Dec 27, 2024

View reviewed changes

- getOddNumsAverage changed mapToDouble to map impl

a84d0c0

SSXcorp requested a review from Sanderfuck December 27, 2024 14:30

okuzan approved these changes Dec 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Methods with lambda are implemented #1209

Methods with lambda are implemented #1209

SSXcorp commented Dec 25, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Dec 25, 2024

mateacademy-ai-mentor Dec 25, 2024

mateacademy-ai-mentor Dec 25, 2024

okuzan left a comment

okuzan Dec 25, 2024

okuzan Dec 25, 2024

SSXcorp Dec 26, 2024

okuzan Dec 25, 2024

sarakhmen left a comment

Sanderfuck Dec 27, 2024

		.orElseThrow(() -> new RuntimeException("Can't get min value from list: "
		+ numbers));

Methods with lambda are implemented #1209

Are you sure you want to change the base?

Methods with lambda are implemented #1209

Conversation

SSXcorp commented Dec 25, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okuzan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarakhmen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment