-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jv-stream-github-practice-01 #1212
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,25 @@ | ||||||
package practice; | ||||||
|
||||||
public class CandidateValidator { | ||||||
//write your code here | ||||||
import java.util.Arrays; | ||||||
import java.util.function.Predicate; | ||||||
import model.Candidate; | ||||||
|
||||||
public class CandidateValidator implements Predicate<Candidate> { | ||||||
private static final int MIN_AGE = 35; | ||||||
private static final int REQUIRED_YEARS = 10; | ||||||
|
||||||
@Override | ||||||
public boolean test(Candidate candidate) { | ||||||
return candidate.getAge() >= MIN_AGE | ||||||
&& candidate.isAllowedToVote() | ||||||
&& "Ukrainian".equalsIgnoreCase(candidate.getNationality()) | ||||||
&& hasLivedInUkraineFor10Years(candidate.getPeriodsInUkr()); | ||||||
} | ||||||
|
||||||
private boolean hasLivedInUkraineFor10Years(String periodsInUkr) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. avoid values in the methods name
Suggested change
|
||||||
return Arrays.stream(periodsInUkr.split(",")) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. create constants for comma and delimiter, for 1 and 0 also |
||||||
.map(period -> period.split("-")) | ||||||
.mapToInt(years -> Integer.parseInt(years[1]) - Integer.parseInt(years[0])) | ||||||
.sum() >= REQUIRED_YEARS; | ||||||
} | ||||||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,29 +1,50 @@ | ||||||
package practice; | ||||||
|
||||||
import java.util.Collections; | ||||||
import java.util.Arrays; | ||||||
import java.util.List; | ||||||
import java.util.NoSuchElementException; | ||||||
import java.util.stream.Collectors; | ||||||
import java.util.stream.IntStream; | ||||||
import model.Candidate; | ||||||
import model.Cat; | ||||||
import model.Person; | ||||||
|
||||||
public class StreamPractice { | ||||||
private static final int MinAge = 35; | ||||||
|
||||||
/** | ||||||
* Given list of strings where each element contains 1+ numbers: | ||||||
* input = {"5,30,100", "0,22,7", ...} | ||||||
* return min integer value. One more thing - we're interested in even numbers. | ||||||
* If there is no needed data throw RuntimeException with message | ||||||
* "Can't get min value from list: < Here is our input 'numbers' >" | ||||||
*/ | ||||||
|
||||||
public int findMinEvenNumber(List<String> numbers) { | ||||||
return 0; | ||||||
return numbers.stream() | ||||||
.flatMap(line -> Arrays.stream(line.split(","))) | ||||||
.map(Integer::parseInt) | ||||||
.filter(n -> n % 2 == 0) | ||||||
.min(Integer::compare) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
It’s default behavior |
||||||
.orElseThrow(() -> | ||||||
new RuntimeException("Can't get min value from list:" + numbers)); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The exception message in the |
||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of Integer numbers, | ||||||
* return the average of all odd numbers from the list or throw NoSuchElementException. | ||||||
* But before that subtract 1 from each element on an odd position (having the odd index). | ||||||
*/ | ||||||
|
||||||
public Double getOddNumsAverage(List<Integer> numbers) { | ||||||
return 0D; | ||||||
return IntStream.range(0, numbers.size()) | ||||||
.map(index -> (index % 2 != 0) | ||||||
? numbers.get(index) - 1 | ||||||
: numbers.get(index)) | ||||||
.filter(n -> n % 2 != 0) | ||||||
.average() | ||||||
.orElseThrow(() | ||||||
-> new NoSuchElementException("Can't get min value from list: " + numbers)); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The exception message here refers to getting the minimum value, but this method is about calculating the average. Consider updating the message to reflect the correct operation, such as: "Can't get average value from list: " + numbers. |
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -34,8 +55,14 @@ public Double getOddNumsAverage(List<Integer> numbers) { | |||||
* <p> | ||||||
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||||||
*/ | ||||||
|
||||||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getSex() | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rename p |
||||||
.equals(Person.Sex.MAN) | ||||||
&& p.getAge() >= fromAge | ||||||
&& p.getAge() <= toAge) | ||||||
.collect(Collectors.toList()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for all places
Suggested change
|
||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -48,18 +75,30 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA | |||||
* Example: select people of working age | ||||||
* (from 18 y.o. and to 60 y.o. for men and to 55 y.o. for women inclusively). | ||||||
*/ | ||||||
|
||||||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||||||
int maleToAge, List<Person> peopleList) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(p -> p.getAge() >= fromAge | ||||||
&& (p.getSex().equals(Person.Sex.MAN) | ||||||
&& p.getAge() <= maleToAge || p.getSex().equals(Person.Sex.WOMAN) | ||||||
&& p.getAge() <= femaleToAge)) | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Given a List of `Person` instances (having `name`, `age`, `sex` and `cats` fields, | ||||||
* and each `Cat` having a `name` and `age`), | ||||||
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||||||
*/ | ||||||
|
||||||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||||||
return Collections.emptyList(); | ||||||
return peopleList.stream() | ||||||
.filter(pw -> pw.getSex() | ||||||
.equals(Person.Sex.WOMAN) && pw.getAge() > femaleAge) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The condition |
||||||
.flatMap(person -> person.getCats().stream()) | ||||||
.map(Cat::getName) | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
|
||||||
/** | ||||||
|
@@ -74,7 +113,13 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | |||||
* We want to reuse our validation in future, so let's write our own impl of Predicate | ||||||
* parametrized with Candidate in CandidateValidator. | ||||||
*/ | ||||||
|
||||||
public List<String> validateCandidates(List<Candidate> candidates) { | ||||||
return Collections.emptyList(); | ||||||
CandidateValidator candidateValidator = new CandidateValidator(); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. better make it a class-level variable |
||||||
return candidates.stream() | ||||||
.filter(candidateValidator) | ||||||
.map(Candidate::getName) | ||||||
.sorted() | ||||||
.collect(Collectors.toList()); | ||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create constant for
"Ukrainian"