-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Practice Completed #1216
Open
MishaHMK
wants to merge
3
commits into
mate-academy:main
Choose a base branch
from
MishaHMK:task
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Practice Completed #1216
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,23 @@ | ||
package practice; | ||
|
||
public class CandidateValidator { | ||
//write your code here | ||
import java.util.function.Predicate; | ||
import model.Candidate; | ||
|
||
public class CandidateValidator implements Predicate<Candidate> { | ||
private static final int MINIMUM_AGE = 35; | ||
private static final int MIN_YEARS_IN_UKRAINE = 10; | ||
private static final String REQUIRED_NATIONALITY = "Ukrainian"; | ||
private static final String SEPARATOR = "-"; | ||
|
||
@Override | ||
public boolean test(Candidate candidate) { | ||
int startYear = Integer.parseInt(candidate.getPeriodsInUkr().split(SEPARATOR)[0]); | ||
int endYear = Integer.parseInt(candidate.getPeriodsInUkr().split(SEPARATOR)[1]); | ||
int yearsInUkraine = endYear - startYear; | ||
|
||
return candidate.isAllowedToVote() | ||
&& candidate.getNationality().equals(REQUIRED_NATIONALITY) | ||
&& candidate.getAge() >= MINIMUM_AGE | ||
&& yearsInUkraine >= MIN_YEARS_IN_UKRAINE; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,17 @@ | ||
package practice; | ||
|
||
import java.util.Collections; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import java.util.NoSuchElementException; | ||
import java.util.function.Predicate; | ||
import java.util.stream.IntStream; | ||
import model.Candidate; | ||
import model.Cat; | ||
import model.Person; | ||
|
||
public class StreamPractice { | ||
public static final CandidateValidator validator = new CandidateValidator(); | ||
|
||
/** | ||
* Given list of strings where each element contains 1+ numbers: | ||
* input = {"5,30,100", "0,22,7", ...} | ||
|
@@ -14,7 +20,17 @@ public class StreamPractice { | |
* "Can't get min value from list: < Here is our input 'numbers' >" | ||
*/ | ||
public int findMinEvenNumber(List<String> numbers) { | ||
return 0; | ||
final String errorMessage = "Can't get min value from list: " + numbers; | ||
|
||
if (numbers.isEmpty()) { | ||
throw new RuntimeException(errorMessage); | ||
} | ||
return Arrays.stream(String.join(",", numbers) | ||
.split(",")) | ||
.map(Integer::parseInt) | ||
.filter(i -> i % 2 == 0) | ||
.min(Integer::compareTo) | ||
.orElseThrow(() -> new RuntimeException(errorMessage)); | ||
} | ||
|
||
/** | ||
|
@@ -23,7 +39,12 @@ public int findMinEvenNumber(List<String> numbers) { | |
* But before that subtract 1 from each element on an odd position (having the odd index). | ||
*/ | ||
public Double getOddNumsAverage(List<Integer> numbers) { | ||
return 0D; | ||
return IntStream.range(0, numbers.size()) | ||
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i)) | ||
.filter(n -> n % 2 != 0) | ||
.average() | ||
.orElseThrow(() -> | ||
new NoSuchElementException("No odd number found in list")); | ||
} | ||
|
||
/** | ||
|
@@ -35,7 +56,13 @@ public Double getOddNumsAverage(List<Integer> numbers) { | |
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||
*/ | ||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||
return Collections.emptyList(); | ||
Predicate<Person> manByAgePredicate = p -> p.getSex() == Person.Sex.MAN | ||
&& p.getAge() >= fromAge | ||
&& p.getAge() <= toAge; | ||
|
||
return peopleList.stream() | ||
.filter(manByAgePredicate) | ||
.toList(); | ||
} | ||
|
||
/** | ||
|
@@ -50,7 +77,16 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA | |
*/ | ||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||
int maleToAge, List<Person> peopleList) { | ||
return Collections.emptyList(); | ||
Predicate<Person> workablePredicate = p -> | ||
(p.getSex() == Person.Sex.WOMAN | ||
&& p.getAge() <= femaleToAge) | ||
|| (p.getSex() == Person.Sex.MAN | ||
&& p.getAge() <= maleToAge); | ||
Comment on lines
+80
to
+84
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider including the lower bound age check (fromAge) within the |
||
|
||
return peopleList.stream() | ||
.filter(p -> p.getAge() >= fromAge) | ||
.filter(workablePredicate) | ||
.toList(); | ||
} | ||
|
||
/** | ||
|
@@ -59,7 +95,13 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | |
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||
*/ | ||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
return Collections.emptyList(); | ||
return peopleList.stream() | ||
.filter(p -> p.getSex() == Person.Sex.WOMAN | ||
&& p.getAge() >= femaleAge | ||
&& !p.getCats().isEmpty()) | ||
.flatMap(p -> p.getCats().stream()) | ||
.map(Cat::getName) | ||
.toList(); | ||
} | ||
|
||
/** | ||
|
@@ -75,6 +117,10 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | |
* parametrized with Candidate in CandidateValidator. | ||
*/ | ||
public List<String> validateCandidates(List<Candidate> candidates) { | ||
return Collections.emptyList(); | ||
return candidates.stream() | ||
.filter(validator) | ||
.map(Candidate::getName) | ||
.sorted() | ||
.toList(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant check (stream returns the same result )