Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice Completed #1216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
private static final int MINIMUM_AGE = 35;
private static final int MIN_YEARS_IN_UKRAINE = 10;
private static final String REQUIRED_NATIONALITY = "Ukrainian";

@Override
public boolean test(Candidate candidate) {
int startYear = Integer.parseInt(candidate.getPeriodsInUkr().split("-")[0]);
int endYear = Integer.parseInt(candidate.getPeriodsInUkr().split("-")[1]);
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved
int yearsInUkraine = endYear - startYear;

return candidate.isAllowedToVote()
&& candidate.getAge() >= MINIMUM_AGE
&& candidate.getNationality().equals(REQUIRED_NATIONALITY)
&& yearsInUkraine >= MIN_YEARS_IN_UKRAINE;
}
}
64 changes: 57 additions & 7 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.function.Predicate;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
Expand All @@ -14,7 +19,21 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
final String errorMessage = "Can't get min value from list: " + numbers;

if (numbers.isEmpty()) {
throw new RuntimeException(errorMessage);
}
Comment on lines +25 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant check (stream returns the same result )


return Arrays.stream(numbers.stream()
.collect(Collectors.joining(","))
.split(","))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Arrays.stream(numbers.stream()
.collect(Collectors.joining(","))
.split(","))
return Arrays.stream(numbers.split(","))

Redundant converting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my input example -> {"5,30,100", "0,22,7", ...}

so i must connect this strings in single one before splitting

am i wrong?

.distinct()
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved
.map(Integer::parseInt)
.filter(i -> i % 2 == 0)
.min(Integer::compareTo)
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved
.orElseThrow(() -> new RuntimeException(errorMessage));

}

/**
Expand All @@ -23,7 +42,12 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
return IntStream.range(0, numbers.size())
.map(i -> i % 2 != 0 ? numbers.get(i) - 1 : numbers.get(i))
.filter(n -> n % 2 != 0)
.average()
.orElseThrow(() ->
new NoSuchElementException("No odd number found in list"));
}

/**
Expand All @@ -35,7 +59,13 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
Predicate<Person> agePredicate = p -> p.getAge() >= fromAge
&& p.getAge() <= toAge
&& p.getSex() == Person.Sex.MAN;
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved

return peopleList.stream()
.filter(agePredicate)
.collect(Collectors.toList());
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand All @@ -50,7 +80,16 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
Predicate<Person> workablePredicate = p ->
(p.getSex() == Person.Sex.WOMAN
&& p.getAge() <= femaleToAge)
|| (p.getSex() == Person.Sex.MAN
&& p.getAge() <= maleToAge);
Comment on lines +80 to +84

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider including the lower bound age check (fromAge) within the workablePredicate to avoid redundancy and improve readability.


return peopleList.stream()
.filter(p -> p.getAge() >= fromAge)
.filter(workablePredicate)
.collect(Collectors.toList());
}

/**
Expand All @@ -59,7 +98,13 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex() == Person.Sex.WOMAN
&& p.getAge() >= femaleAge
&& !p.getCats().isEmpty())
.flatMap(p -> p.getCats().stream())
.map(Cat::getName)
.collect(Collectors.toList());
}

/**
Expand All @@ -75,6 +120,11 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
CandidateValidator validator = new CandidateValidator();
MishaHMK marked this conversation as resolved.
Show resolved Hide resolved
return candidates.stream()
.filter(validator)
.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());
}
}
Loading