Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement all methods #1220

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,39 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.Arrays;
import java.util.List;
import java.util.function.Predicate;
import java.util.stream.Collectors;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
@Override
public boolean test(Candidate candidate) {
if (candidate == null) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you simplify solution by using logical operators?

return false;
}
if (!"Ukrainian".equals(candidate.getNationality())) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a constant for the nationality string "Ukrainian" to improve readability and maintainability. This aligns with the checklist advice to avoid magic strings.

return false;
}
if (candidate.getAge() < 35) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a constant for the age requirement (35) to improve readability and maintainability. This aligns with the checklist advice to avoid magic numbers.

return false;
}
if (!candidate.isAllowedToVote()) {
return false;
}
try {
List<Integer> periodInUkraine = Arrays.stream(candidate.getPeriodsInUkr().split("-"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make separator constant field

.map(String::trim)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.map(String::trim)

.map(Integer::valueOf)
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before splitting and processing the periodsInUkr string, ensure it is not null or empty to avoid potential exceptions.

if (periodInUkraine.size() != 2
|| periodInUkraine.get(1) - periodInUkraine.get(0) < 10) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a constant for the minimum residency period (10 years) to improve readability and maintainability. This aligns with the checklist advice to avoid magic numbers.

return false;
}
} catch (NumberFormatException | IndexOutOfBoundsException e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} catch (NumberFormatException | IndexOutOfBoundsException e) {
} catch (NumberFormatException e) {

you validated the collection size

return false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider validating the format of the periodsInUkr string before parsing to integers to improve exception handling.

}
return true;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave only one line at the end of the file

50 changes: 42 additions & 8 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
Expand All @@ -14,7 +18,16 @@ public class StreamPractice {
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the numbers list is null or empty before processing to avoid potential NullPointerException.

.map(s -> s.split(","))
.flatMap(Arrays::stream)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine into one map

.map(String::trim)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

.map(Integer::valueOf)
.filter(i -> i % 2 == 0)
.min(Integer::compareTo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.min(Integer::compareTo)
.min()

It is the default behavior

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got error of compilation :(

изображение_2025-01-20_132455322

.orElseThrow(() -> new RuntimeException(
"Can't get min value from list: " + numbers
));
}

/**
Expand All @@ -23,7 +36,12 @@ public int findMinEvenNumber(List<String> numbers) {
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the numbers list is null or empty before processing to avoid potential NullPointerException.

return 0D;

return IntStream.range(0, numbers.size())
.map(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i))
.filter(num -> num % 2 != 0)
.average()
.orElseThrow(NoSuchElementException::new);
}

/**
Expand All @@ -35,7 +53,10 @@ public Double getOddNumsAverage(List<Integer> numbers) {
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the peopleList is null or empty before processing to avoid potential NullPointerException.

return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getAge() >= fromAge && p.getAge() <= toAge)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename p

.filter(p -> p.getSex() == Person.Sex.MAN)
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all places

Suggested change
.collect(Collectors.toList());
.toList();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed

}

/**
Expand All @@ -50,7 +71,11 @@ public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toA
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the peopleList is null or empty before processing to avoid potential NullPointerException.

int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getAge() >= fromAge)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename p

.filter((p -> (p.getSex() == Person.Sex.WOMAN && p.getAge() <= femaleToAge)
|| (p.getSex() == Person.Sex.MAN && p.getAge() <= maleToAge)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.filter((p -> (p.getSex() == Person.Sex.WOMAN && p.getAge() <= femaleToAge)
|| (p.getSex() == Person.Sex.MAN && p.getAge() <= maleToAge)))
.filter(p -> (p.getSex() == Person.Sex.WOMAN && p.getAge() <= femaleToAge
|| p.getSex() == Person.Sex.MAN && p.getAge() <= maleToAge))

.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList());
.toList();

}

/**
Expand All @@ -59,10 +84,15 @@ public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the peopleList is null or empty before processing to avoid potential NullPointerException.

return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex() == Person.Sex.WOMAN)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename p

.filter(p -> p.getAge() >= femaleAge)
.flatMap(c -> c.getCats().stream())

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename c

.map(Cat::getName)
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList());
.toList();

}

/**
/** V - wtf MA, wrong article

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert changes

* Your help with a election is needed. Given list of candidates, where each element
* has Candidate.class type.
* Check which candidates are eligible to apply for president position and return their
Expand All @@ -75,6 +105,10 @@ public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if the candidates list is null or empty before processing to avoid potential NullPointerException.

return Collections.emptyList();
return candidates.stream()
.filter(new CandidateValidator())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better make CandidateValidator class-level variable

.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList());
.toList();

}
}
Loading