Add implementation for the Stream API Practice task #910

MinoDentori · 2023-10-25T20:23:38Z

No description provided.

… Predicate<Candidate> interface.

Clean up code Pass tests.

src/main/java/practice/CandidateValidator.java

src/main/java/practice/StreamPractice.java

bhdnchui

Good job! But a few points need to be processed.

bhdnchui · 2023-10-27T15:24:15Z

src/main/java/practice/StreamPractice.java

+                .flatMap(s -> Arrays.stream(s.split(",")))
+                .map(Integer::parseInt)
+                .toList();
+        return allNumbers


Make it one stream.

bhdnchui · 2023-10-27T15:24:21Z

src/main/java/practice/StreamPractice.java

+        return allNumbers
+                .stream()
+                .filter(n -> n % 2 == 0)
+                .min(Integer::compareTo)


I think you can call min() without arguments.

bhdnchui · 2023-10-27T15:25:20Z

src/main/java/practice/StreamPractice.java

+                .range(0, numbers.size())
+                .filter(i -> i % 2 != 0)
+                .forEach(i -> numbers.set(i, numbers.get(i) - 1));
+        return numbers


Make one stream for all logic here.

bhdnchui · 2023-10-27T15:25:48Z

src/main/java/practice/StreamPractice.java

+                .forEach(i -> numbers.set(i, numbers.get(i) - 1));
+        return numbers
+                .stream()
+                .filter(n -> n % 2 != 0)


Think abut avoiding n -> n % 2 != 0 code duplication.

bhdnchui · 2023-10-27T15:28:07Z

src/main/java/practice/StreamPractice.java

+        List<Integer> allNumbers = numbers
+                .stream()
+                .flatMap(s -> Arrays.stream(s.split(",")))


Suggested change

List<Integer> allNumbers = numbers

.stream()

.flatMap(s -> Arrays.stream(s.split(",")))

List<Integer> allNumbers = numbers.stream()

.flatMap(s -> Arrays.stream(s.split(",")))

It would be better not place stream() in new line.

bhdnchui · 2023-10-27T15:29:25Z

src/main/java/practice/StreamPractice.java

-        return Collections.emptyList();
+        return peopleList
+                .stream()
+                .filter(person -> person.getSex().equals(Person.Sex.MAN)


Suggested change

.filter(person -> person.getSex().equals(Person.Sex.MAN)

.filter(person -> Person.Sex.MAN.equals(person.getSex())

Let's avoid NPE.

bhdnchui · 2023-10-27T15:29:42Z

src/main/java/practice/StreamPractice.java

+                .filter(person -> person.getSex().equals(Person.Sex.MAN)
+                        && person.getAge() >= fromAge
+                        && person.getAge() <= toAge)
+                .collect(Collectors.toList());


Suggested change

.collect(Collectors.toList());

.toList();

Be sure to make it everywhere.

bhdnchui · 2023-10-27T15:31:30Z

src/main/java/practice/StreamPractice.java

+                .filter(person -> person.getAge() >= fromAge
+                        && (person.getSex().equals(Person.Sex.WOMAN)
+                        && person.getAge() <= femaleToAge
+                        || person.getSex().equals(Person.Sex.MAN)
+                        && person.getAge() <= maleToAge))


getAge() 3 times.
getAge() 2 times.
Lets make variables for it.

bhdnchui · 2023-10-27T15:33:30Z

src/main/java/practice/CandidateValidator.java

+    @Override
+    public boolean test(Candidate candidate) {
+        String[] periodInUkr = candidate.getPeriodsInUkr().split("-");
+        int yearsInUkr = Integer.parseInt(periodInUkr[1]) - Integer.parseInt(periodInUkr[0]);


Let's make constants for indexes here.

bhdnchui · 2023-10-27T15:34:06Z

src/main/java/practice/StreamPractice.java

-        return 0;
+        List<Integer> allNumbers = numbers
+                .stream()
+                .flatMap(s -> Arrays.stream(s.split(",")))


Let's make constant for regex.

bhdnchui

Good job.
A few minor comments need to be processed.

src/main/java/practice/CandidateValidator.java

src/main/java/practice/StreamPractice.java

bhdnchui · 2023-10-30T07:18:28Z

src/main/java/practice/StreamPractice.java

@@ -14,16 +20,31 @@ public class StreamPractice {
     * "Can't get min value from list: < Here is our input 'numbers' >"
     */
    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        return numbers.stream()
+                .flatMap(s -> Arrays.stream(s.split(STRING_SPLITTER)))


Let's dont use one-letter names.

I guess in this kind of situations it's like i in for, fixed.

src/main/java/practice/StreamPractice.java

bhdnchui

Good job!

MinoDentori added 2 commits October 25, 2023 23:21

Add implementation for the CandidateValidator class, which implements…

633c3c1

… Predicate<Candidate> interface.

Add implementation for the tasks according to the descriptions.

5a22110

Clean up code Pass tests.

ponomvrenko suggested changes Oct 26, 2023

View reviewed changes

MinoDentori added 2 commits October 27, 2023 13:26

Fixed comments

b333346

Fixed student comments with mentor help.

3a04d94

bhdnchui suggested changes Oct 27, 2023

View reviewed changes

MinoDentori added 3 commits October 27, 2023 19:28

Create constants

0186a83

Fix comments

76c9312

Fix comments

2e45493

bhdnchui suggested changes Oct 30, 2023

View reviewed changes

Fix comments (FINAL)

c6e82d6

bhdnchui approved these changes Oct 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add implementation for the Stream API Practice task #910

Add implementation for the Stream API Practice task #910

MinoDentori commented Oct 25, 2023

bhdnchui left a comment

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui Oct 27, 2023

MinoDentori Oct 28, 2023

bhdnchui left a comment

bhdnchui Oct 30, 2023

MinoDentori Oct 30, 2023

bhdnchui left a comment

	.filter(person -> person.getSex().equals(Person.Sex.MAN)
	.filter(person -> Person.Sex.MAN.equals(person.getSex())

Add implementation for the Stream API Practice task #910

Are you sure you want to change the base?

Add implementation for the Stream API Practice task #910

Conversation

MinoDentori commented Oct 25, 2023

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment