-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created first version of the program. #912
Open
ponomvrenko
wants to merge
6
commits into
mate-academy:main
Choose a base branch
from
ponomvrenko:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e06901e
Created first version of the program.
ponomvrenko 031e29e
Student review changes:
ponomvrenko 7ff3a0e
Created constants, optimized getOddNumsAverage(), created a new metho…
ponomvrenko b6ab569
Merge remote-tracking branch 'origin/main'
ponomvrenko 26fb41b
Optimized findMinEvenNumber & getOddNumsAverage(), created a new meth…
ponomvrenko 656051a
Minor updates
ponomvrenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,27 @@ | ||
package practice; | ||
|
||
public class CandidateValidator { | ||
//write your code here | ||
import java.util.function.Predicate; | ||
import model.Candidate; | ||
|
||
public class CandidateValidator implements Predicate<Candidate> { | ||
private static final int MIN_YEARS_OLD = 35; | ||
private static final int MIN_TOTAL_DURATION = 10; | ||
private static final String VALID_NATIONALITY = "Ukrainian"; | ||
private static final String REGEX = "-"; | ||
private static final int SINCE_YEAR_INDEX = 0; | ||
private static final int TO_YEAR_INDEX = 1; | ||
|
||
@Override | ||
public boolean test(Candidate candidate) { | ||
if (candidate.getAge() >= MIN_YEARS_OLD && candidate.isAllowedToVote() | ||
&& VALID_NATIONALITY.equals(candidate.getNationality())) { | ||
String[] years = candidate.getPeriodsInUkr().split(REGEX); | ||
|
||
int totalDuration = Integer.parseInt(years[TO_YEAR_INDEX]) | ||
- Integer.parseInt(years[SINCE_YEAR_INDEX]); | ||
|
||
return totalDuration >= MIN_TOTAL_DURATION; | ||
} | ||
return false; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if there is an average number. If there is not, throw NoSuchElementException according to the task requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhdnchui I have there getAsDouble() method that includes
if (!isPresent) { throw new NoSuchElementException("No value present"); }
Is my solution here incorrect?