Implemented all methods #916

YevheniiVlasenko · 2023-10-27T15:14:11Z

No description provided.

TymurPanchenk0 · 2023-10-27T15:23:22Z

src/main/java/practice/CandidateValidator.java

+                && candidate.getAge() >= 35
+                && candidate.getNationality().equals("Ukrainian")) {
+            int startYear = Integer.parseInt(
+                    candidate.getPeriodsInUkr().split("-")[0]);
+            int endYear = Integer.parseInt(
+                    candidate.getPeriodsInUkr().split("-")[1]);
+            return endYear - startYear >= 10;


Don`t use magic numbers

TymurPanchenk0 · 2023-10-27T15:23:48Z

src/main/java/practice/StreamPractice.java

+            .filter(e -> e % 2 == 0)
+            .sorted()
+            .findFirst()
+            .orElseThrow(() -> new RuntimeException("Can't get min value from list: " + numbers));


Should be constant

TymurPanchenk0 · 2023-10-27T15:23:53Z

src/main/java/practice/StreamPractice.java

+            })
+            .filter(number -> number % 2 != 0)
+            .average()
+            .orElseThrow(() -> new NoSuchElementException("Empty List provided"));


Should be constant

bhdnchui

Good job!
A few comments need to be process.

bhdnchui · 2023-10-27T16:02:08Z

src/main/java/practice/CandidateValidator.java

+            int startYear = Integer.parseInt(
+                    candidate.getPeriodsInUkr().split("-")[0]);
+            int endYear = Integer.parseInt(
+                    candidate.getPeriodsInUkr().split("-")[1]);


Let's make one variable for data that indicates how long a candidate is in country.
Also, it would be great to make constants for index numbers. Constant names will descript what item you take.
Double .split("-") call. Make constant for "-"

Sorry, refactored a little, but I can make it only in one barely readable line.
Could you please make a suggestion?

bhdnchui · 2023-10-27T16:03:53Z

src/main/java/practice/StreamPractice.java

    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        return numbers.stream()
+            .map(e -> e.split(","))


Let's not use one-letter names.

Make constant for comma.

bhdnchui · 2023-10-27T16:04:57Z

src/main/java/practice/StreamPractice.java

+                if (index % 2 != 0) {
+                    return numbers.get(index) - 1;
+                }
+                return numbers.get(index);


I think we can reduce code by providing a ternary operator.

bhdnchui · 2023-10-27T16:05:41Z

src/main/java/practice/StreamPractice.java

+                }
+                return numbers.get(index);
+            })
+            .filter(number -> number % 2 != 0)


Lets avoid duplication of code that checks odd/even number.

Also, need a suggestion here. Spent more than an hour on this

bhdnchui · 2023-10-27T16:06:28Z

src/main/java/practice/StreamPractice.java

-        return Collections.emptyList();
+        return peopleList.stream()
+            .filter(person -> person.getAge() >= fromAge && person.getAge() <= toAge)
+            .filter(person -> person.getSex().name().equals("MAN"))


Let's use enum instead string literal.

bhdnchui · 2023-10-27T16:06:47Z

src/main/java/practice/StreamPractice.java

    public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
-        return Collections.emptyList();
+        return peopleList.stream()
+            .filter(person -> person.getAge() >= fromAge && person.getAge() <= toAge)


Double getAge method call.

bhdnchui · 2023-10-27T16:08:06Z

src/main/java/practice/StreamPractice.java

+                    return person.getAge() >= fromAge && person.getAge() <= maleToAge;
+                }
+                return person.getAge() >= fromAge && person.getAge() <= femaleToAge;


Make a variable for name.

bhdnchui · 2023-10-27T16:08:29Z

src/main/java/practice/StreamPractice.java

+        Predicate<Person> isWorkable = new Predicate<Person>() {
+            @Override
+            public boolean test(Person person) {
+                if (person.getSex().name().equals("MAN")) {


bhdnchui · 2023-10-27T16:10:02Z

src/main/java/practice/StreamPractice.java

+            .map(e -> e.split(","))
+            .flatMap(Arrays::stream)
+            .map(Integer::parseInt)
+            .filter(e -> e % 2 == 0)


One-letter name

bhdnchui · 2023-10-27T16:10:43Z

src/main/java/practice/StreamPractice.java

    public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
-                                          int maleToAge, List<Person> peopleList) {
-        return Collections.emptyList();
+            int maleToAge, List<Person> peopleList) {


Format that line of code.

I think 54 line should be positioned further to the right than it is now.
Like line 52 on the screen. Add tabs.

bhdnchui

Good job, but a few comments need to be processed.

bhdnchui · 2023-10-30T07:03:19Z

src/main/java/practice/StreamPractice.java

+            .filter(number -> number % 2 == 0)
+            .sorted()
+            .findFirst()
+            .orElseThrow(() -> new RuntimeException(NO_MIN_VALUE_EXCEPTION_MESSAGE + numbers));
    }



Suggested change

.filter(number -> number % 2 == 0)

.sorted()

.findFirst()

.orElseThrow(() -> new RuntimeException(NO_MIN_VALUE_EXCEPTION_MESSAGE + numbers));

}

.filter(number -> !isOddNumber(number))

.sorted()

.findFirst()

.orElseThrow(() -> new RuntimeException(NO_MIN_VALUE_EXCEPTION_MESSAGE + numbers));

}

private static boolean isOddNumber(int number) {

return number % 2 != 0;

}

bhdnchui · 2023-10-30T07:04:24Z

src/main/java/practice/StreamPractice.java

+                int personAge = person.getAge();
+                ;
+                return personAge >= fromAge
+                    && personAge <= toAge
+                    && person.getSex().equals(Sex.MAN);


Suggested change

int personAge = person.getAge();

;

return personAge >= fromAge

&& personAge <= toAge

&& person.getSex().equals(Sex.MAN);

int personAge = person.getAge();

return personAge >= fromAge

&& personAge <= toAge

&& Sex.MAN.equals(person.getSex());

It will avoid NPE.

bhdnchui · 2023-10-30T07:08:11Z

src/main/java/practice/StreamPractice.java

    public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
-                                          int maleToAge, List<Person> peopleList) {
-        return Collections.emptyList();
+            int maleToAge, List<Person> peopleList) {


I think 54 line should be positioned further to the right than it is now.
Like line 52 on the screen. Add tabs.

bhdnchui · 2023-10-30T07:08:47Z

src/main/java/practice/StreamPractice.java

+            int maleToAge, List<Person> peopleList) {
+        Predicate<Person> isWorkable = person -> {
+            int personAge = person.getAge();
+            if (person.getSex().equals(Sex.MAN)) {


Suggested change

if (person.getSex().equals(Sex.MAN)) {

if (Sex.MAN.equals(person.getSex())) {

bhdnchui

Good job!

YevheniiVlasenko added 2 commits October 27, 2023 17:34

init commit

0b1231f

refactored

aafd0ab

TymurPanchenk0 suggested changes Oct 27, 2023

View reviewed changes

added constants

b949cb8

TymurPanchenk0 approved these changes Oct 27, 2023

View reviewed changes

bhdnchui suggested changes Oct 27, 2023

View reviewed changes

fixed (almost), need suggestions

6e7fa4d

bhdnchui suggested changes Oct 30, 2023

View reviewed changes

fixed according to comments

acd210f

bhdnchui approved these changes Oct 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented all methods #916

Implemented all methods #916

YevheniiVlasenko commented Oct 27, 2023

TymurPanchenk0 Oct 27, 2023

TymurPanchenk0 Oct 27, 2023

TymurPanchenk0 Oct 27, 2023

bhdnchui left a comment

bhdnchui Oct 27, 2023

YevheniiVlasenko Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

YevheniiVlasenko Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 27, 2023

bhdnchui Oct 30, 2023

bhdnchui left a comment

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui left a comment

	if (person.getSex().equals(Sex.MAN)) {
	if (Sex.MAN.equals(person.getSex())) {

Implemented all methods #916

Are you sure you want to change the base?

Implemented all methods #916

Conversation

YevheniiVlasenko commented Oct 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment