added method implementations and created a CandidateValidator #921

DevIgork · 2023-10-29T13:31:28Z

No description provided.

…more descriptive , changed user name from expected to user

Andriy-Hrynevetskyi · 2023-10-29T13:40:49Z

src/main/java/practice/CandidateValidator.java

+        String[] ages = candidate.getPeriodsInUkr().split("-");
+        int ageFrom = Integer.parseInt(ages[0]);
+        int ageTo = Integer.parseInt(ages[1]);
+        return candidate.getAge() >= 35
+                && candidate.isAllowedToVote()
+                && candidate.getNationality().equals("Ukrainian")
+                && ageTo - ageFrom >= 10;


Hi mate i'm sure that we can move all magic numbers and values to constants.

Andriy-Hrynevetskyi · 2023-10-29T13:43:28Z

src/main/java/practice/StreamPractice.java

@@ -14,7 +17,14 @@ public class StreamPractice {
     * "Can't get min value from list: < Here is our input 'numbers' >"
     */
    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        return numbers.stream().flatMap(num -> {
+            String[] numString = num.split(",");


Probably here we can move comma to constant too

Make constant

Andriy-Hrynevetskyi · 2023-10-29T14:00:19Z

src/main/java/practice/StreamPractice.java

@@ -14,7 +17,14 @@ public class StreamPractice {
     * "Can't get min value from list: < Here is our input 'numbers' >"


Remove all task descriptions from your code

Andriy-Hrynevetskyi · 2023-10-29T14:00:50Z

src/main/java/practice/StreamPractice.java

+                        && pepl.getAge() <= maleToAge
+                        : pepl.getAge() >= fromAge
+                        && pepl.getAge() <= femaleToAge
+                ).collect(Collectors.toList());
    }



Andriy-Hrynevetskyi · 2023-10-29T14:01:05Z

src/main/java/practice/StreamPractice.java

+                .flatMap(pepl -> pepl.getCats()
+                        .stream()
+                        .map(cat -> cat.getName()))
+                .collect(Collectors.toList());
    }


Andriy-Hrynevetskyi · 2023-10-29T14:01:31Z

src/main/java/practice/StreamPractice.java

+        return peopleList.stream()
+                .filter(person -> person.getSex() == Person.Sex.MAN
+                        && person.getAge() > fromAge && person.getAge() <= toAge)
+                .collect(Collectors.toList());
    }

    /**


Andriy-Hrynevetskyi · 2023-10-29T14:02:00Z

src/main/java/practice/StreamPractice.java

+                .mapToInt(n -> n)
+                .average()
+                .orElseThrow(NoSuchElementException::new);
+
    }

    /**


Andriy-Hrynevetskyi · 2023-10-29T14:02:16Z

src/main/java/practice/StreamPractice.java

+                    .filter(n -> n % 2 == 0);
+        }).min(Integer::compareTo)
+                .orElseThrow(() -> new RuntimeException("Can't get min value from list: "
+                        + numbers));
    }



I forgot about it, thank you.

bhdnchui

Good job, but a few points need to be processed,

bhdnchui · 2023-10-30T08:41:30Z

src/main/java/practice/CandidateValidator.java

+public class CandidateValidator implements Predicate<Candidate> {
+    @Override
+    public boolean test(Candidate candidate) {
+        String[] ages = candidate.getPeriodsInUkr().split("-");


Let's find better name
Make constant for "-"

bhdnchui · 2023-10-30T08:41:47Z

src/main/java/practice/CandidateValidator.java

+        int ageFrom = Integer.parseInt(ages[0]);
+        int ageTo = Integer.parseInt(ages[1]);


Let's create constants for indexes.

bhdnchui · 2023-10-30T08:42:22Z

src/main/java/practice/CandidateValidator.java

+        return candidate.getAge() >= 35
+                && candidate.isAllowedToVote()
+                && candidate.getNationality().equals("Ukrainian")
+                && ageTo - ageFrom >= 10;


Let's create constansts for ages and nationality.

bhdnchui · 2023-10-30T08:42:54Z

src/main/java/practice/CandidateValidator.java

+        int ageTo = Integer.parseInt(ages[1]);
+        return candidate.getAge() >= 35
+                && candidate.isAllowedToVote()
+                && candidate.getNationality().equals("Ukrainian")


Suggested change

&& candidate.getNationality().equals("Ukrainian")

&& UKRAINIAN.equals(candidate.getNationality())

bhdnchui · 2023-10-30T08:43:17Z

src/main/java/practice/StreamPractice.java

@@ -14,7 +17,14 @@ public class StreamPractice {
     * "Can't get min value from list: < Here is our input 'numbers' >"
     */
    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        return numbers.stream().flatMap(num -> {
+            String[] numString = num.split(",");


Make constant

bhdnchui · 2023-10-30T08:50:08Z

src/main/java/practice/StreamPractice.java

+                .flatMap(pepl -> pepl.getCats()
+                        .stream()
+                        .map(cat -> cat.getName()))


Let's avoid stream in stream

bhdnchui · 2023-10-30T08:50:16Z

src/main/java/practice/StreamPractice.java

+                .flatMap(pepl -> pepl.getCats()
+                        .stream()
+                        .map(cat -> cat.getName()))
+                .collect(Collectors.toList());


bhdnchui · 2023-10-30T08:50:56Z

src/main/java/practice/StreamPractice.java

+        CandidateValidator candidateValidator = new CandidateValidator();
+        return candidates
+                .stream()
+                .filter(candidate -> candidateValidator.test(candidate))


Suggested change

.filter(candidate -> candidateValidator.test(candidate))

.filter(candidateValidator)

bhdnchui · 2023-10-30T08:51:29Z

src/main/java/practice/StreamPractice.java

+        return candidates
+                .stream()
+                .filter(candidate -> candidateValidator.test(candidate))
+                .map(candidate -> candidate.getName())


Suggested change

.map(candidate -> candidate.getName())

.map(Candidate::getName)

bhdnchui · 2023-10-30T08:51:34Z

src/main/java/practice/StreamPractice.java

+                .filter(candidate -> candidateValidator.test(candidate))
+                .map(candidate -> candidate.getName())
+                .sorted()
+                .collect(Collectors.toList());


bhdnchui

Good job!

DevIgork added 3 commits October 26, 2023 10:26

Simplifyed if method in CandidateValidator, changed names in test to …

ba1e04f

…more descriptive , changed user name from expected to user

added method implementations and created a CandidateValidator

f2e58ba

fixed mistakes

2a62d3d

Andriy-Hrynevetskyi suggested changes Oct 29, 2023

View reviewed changes

fixed errors mentioned in the pool request

8f81734

bhdnchui suggested changes Oct 30, 2023

View reviewed changes

fixed errors mentioned in the pool request again

2299e7e

bhdnchui approved these changes Oct 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added method implementations and created a CandidateValidator #921

added method implementations and created a CandidateValidator #921

DevIgork commented Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

bhdnchui Oct 30, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

Andriy-Hrynevetskyi Oct 29, 2023

DevIgork Oct 29, 2023

bhdnchui left a comment

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui left a comment

		@@ -14,7 +17,14 @@ public class StreamPractice {
		* "Can't get min value from list: < Here is our input 'numbers' >"

		int ageFrom = Integer.parseInt(ages[0]);
		int ageTo = Integer.parseInt(ages[1]);

	&& candidate.getNationality().equals("Ukrainian")
	&& UKRAINIAN.equals(candidate.getNationality())

	.filter(candidate -> candidateValidator.test(candidate))
	.filter(candidateValidator)

	.map(candidate -> candidate.getName())
	.map(Candidate::getName)

added method implementations and created a CandidateValidator #921

Are you sure you want to change the base?

added method implementations and created a CandidateValidator #921

Conversation

DevIgork commented Oct 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui left a comment

Choose a reason for hiding this comment