Solution for jv-stream-practice #923

AgroFix · 2023-10-29T13:47:53Z

No description provided.

OlexVoit · 2023-10-29T16:35:40Z

src/main/java/practice/CandidateValidator.java

+    private static final int FROM = 0;
+    private static final int TO = 1;


I believe that these variables are redundant

OlexVoit · 2023-10-29T16:44:28Z

src/main/java/practice/StreamPractice.java

+                .filter(person ->
+                        (person.getSex() == Person.Sex.MAN && person.getAge() >= fromAge
+                                && person.getAge() <= maleToAge)
+                                || (person.getSex() == Person.Sex.WOMAN
+                                && person.getAge() >= fromAge
+                                && person.getAge() <= femaleToAge)


can be taken out of the stream and create a predicate

OlexVoit · 2023-10-29T16:51:05Z

Nice job!
Good luck

bhdnchui

Good job, but a few comments need to be processed.

bhdnchui · 2023-10-30T08:08:20Z

src/main/java/practice/CandidateValidator.java

+    private static final int FROM = 0;
+    private static final int TO = 1;


Let's make more descriptive names.

bhdnchui · 2023-10-30T08:10:32Z

src/main/java/practice/CandidateValidator.java

+
+    @Override
+    public boolean test(Candidate candidate) {
+        String [] interval = candidate.getPeriodsInUkr().split(SEPARATOR);


Try to find better name.

bhdnchui · 2023-10-30T08:10:46Z

src/main/java/practice/CandidateValidator.java

+        int endLivingInUkraine = Integer.parseInt(interval[TO]);
+        return candidate.getAge() >= MIN_AGE
+                && candidate.isAllowedToVote()
+                && candidate.getNationality().equals(NATION)


Suggested change

&& candidate.getNationality().equals(NATION)

&& NATION.equals(candidate.getNationality())

bhdnchui · 2023-10-30T08:11:24Z

src/main/java/practice/StreamPractice.java

    public int findMinEvenNumber(List<String> numbers) {
-        return 0;
+        return numbers.stream()
+                .flatMap(str -> Stream.of(str.split(",")))


Create constant for comma.

bhdnchui · 2023-10-30T08:11:48Z

src/main/java/practice/StreamPractice.java

+                .flatMap(str -> Stream.of(str.split(",")))
+                .map(Integer::parseInt)
+                .filter(num -> num % 2 == 0)
+                .min(Integer::compareTo)


I think you can call min() without arguments.

bhdnchui · 2023-10-30T08:13:26Z

src/main/java/practice/StreamPractice.java

+                        && person.getAge() >= fromAge
+                        && person.getAge() <= toAge)


Let's avoid double getAge method call.

bhdnchui · 2023-10-30T08:13:42Z

src/main/java/practice/StreamPractice.java

+                                && person.getAge() >= fromAge
+                                && person.getAge() <= femaleToAge)
+                )
+                .collect(Collectors.toList());


Suggested change

.collect(Collectors.toList());

.toList();

bhdnchui · 2023-10-30T08:15:23Z

src/main/java/practice/StreamPractice.java

+                        (person.getSex() == Person.Sex.MAN && person.getAge() >= fromAge
+                                && person.getAge() <= maleToAge)
+                                || (person.getSex() == Person.Sex.WOMAN
+                                && person.getAge() >= fromAge
+                                && person.getAge() <= femaleToAge)


Let's create variables to avoid getAge and getSex method calls duplication.
Pay attention to what is a better way to compare Enum values: equals() vs == ?

bhdnchui · 2023-10-30T08:16:00Z

src/main/java/practice/StreamPractice.java

-        return Collections.emptyList();
+        return peopleList.stream()
+                .filter(person -> person.getAge() >= femaleAge
+                        && person.getSex().equals(Person.Sex.WOMAN))


Suggested change

&& person.getSex().equals(Person.Sex.WOMAN))

&& Person.Sex.WOMAN.equals(person.getSex()))

bhdnchui · 2023-10-30T08:16:08Z

src/main/java/practice/StreamPractice.java

+                .map(Person::getCats)
+                .flatMap(Collection::stream)
+                .map(Cat::getName)
+                .collect(Collectors.toList());


kshuryhin

Good job, some points to consider

kshuryhin · 2023-10-30T16:11:38Z

src/main/java/practice/StreamPractice.java

+                .getAsDouble();
+    }
+
+    public static boolean isOdd(int number) {


Should be private I guess

kshuryhin · 2023-10-30T16:13:54Z

src/main/java/practice/StreamPractice.java

+                .filter(person -> {
+                    int age = person.getAge();
+                    Person.Sex sex = person.getSex();
+                    return age >= fromAge
+                            && (Person.Sex.MAN.equals(sex) && age <= maleToAge
+                            || Person.Sex.WOMAN.equals(sex) && age <= femaleToAge);
+                })


I guess we can create separate predicate/method for this long boolean expression, what do you think?

AgroFix added 2 commits October 29, 2023 15:47

Solution for jv-stream-practice

63ef252

Solution for jv-stream-practice

8a0459b

OlexVoit approved these changes Oct 29, 2023

View reviewed changes

bhdnchui suggested changes Oct 30, 2023

View reviewed changes

Fixed some points

6e7a876

kshuryhin suggested changes Oct 30, 2023

View reviewed changes

Fixed some points

1f8333a

kshuryhin approved these changes Oct 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solution for jv-stream-practice #923

Solution for jv-stream-practice #923

AgroFix commented Oct 29, 2023

OlexVoit Oct 29, 2023

OlexVoit Oct 29, 2023

OlexVoit commented Oct 29, 2023

bhdnchui left a comment

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023 •

edited

Loading

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

bhdnchui Oct 30, 2023

kshuryhin left a comment

kshuryhin Oct 30, 2023

kshuryhin Oct 30, 2023

		private static final int FROM = 0;
		private static final int TO = 1;

	&& candidate.getNationality().equals(NATION)
	&& NATION.equals(candidate.getNationality())

	&& person.getSex().equals(Person.Sex.WOMAN))
	&& Person.Sex.WOMAN.equals(person.getSex()))

Solution for jv-stream-practice #923

Are you sure you want to change the base?

Solution for jv-stream-practice #923

Conversation

AgroFix commented Oct 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlexVoit commented Oct 29, 2023

bhdnchui left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kshuryhin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bhdnchui Oct 30, 2023 •

edited

Loading