-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve tasks from Readme file #929
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,28 @@ | ||
package practice; | ||
|
||
public class CandidateValidator { | ||
//write your code here | ||
import java.util.function.Predicate; | ||
import model.Candidate; | ||
|
||
public class CandidateValidator implements Predicate<Candidate> { | ||
private static final int MIN_PERIOD_LIVE_IN_COUNTRY = 10; | ||
private static final int MIN_VALID_AGE = 35; | ||
private static final int FROM_YEAR_INDEX = 0; | ||
private static final int UP_TO_YEAR_INDEX = 1; | ||
private static final String VALID_NATIONALITY = "Ukrainian"; | ||
private static final String DIVIDER_DASH = "-"; | ||
|
||
@Override | ||
public boolean test(Candidate candidate) { | ||
return candidate.isAllowedToVote() | ||
&& candidate.getAge() >= MIN_VALID_AGE | ||
&& VALID_NATIONALITY.equals(candidate.getNationality()) | ||
&& yearsLiveInUkraine(candidate) >= MIN_PERIOD_LIVE_IN_COUNTRY; | ||
} | ||
|
||
private int yearsLiveInUkraine(Candidate candidate) { | ||
String liveInUkraine = candidate.getPeriodsInUkr(); | ||
int fromYear = Integer.parseInt(liveInUkraine.split(DIVIDER_DASH)[FROM_YEAR_INDEX]); | ||
int upToYear = Integer.parseInt(liveInUkraine.split(DIVIDER_DASH)[UP_TO_YEAR_INDEX]); | ||
return upToYear - fromYear; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,80 +1,79 @@ | ||
package practice; | ||
|
||
import java.util.Collections; | ||
import java.util.Arrays; | ||
import java.util.Collection; | ||
import java.util.List; | ||
import java.util.function.Predicate; | ||
import java.util.function.Supplier; | ||
import java.util.stream.IntStream; | ||
import model.Candidate; | ||
import model.Cat; | ||
import model.Person; | ||
|
||
public class StreamPractice { | ||
/** | ||
* Given list of strings where each element contains 1+ numbers: | ||
* input = {"5,30,100", "0,22,7", ...} | ||
* return min integer value. One more thing - we're interested in even numbers. | ||
* If there is no needed data throw RuntimeException with message | ||
* "Can't get min value from list: < Here is our input 'numbers' >" | ||
*/ | ||
private static final String NUMBERS_DIVIDER = "[,]"; | ||
private final CandidateValidator candidateValidator = new CandidateValidator(); | ||
|
||
public int findMinEvenNumber(List<String> numbers) { | ||
return 0; | ||
Supplier<RuntimeException> exceptionSupplier = () -> | ||
new RuntimeException("Can't get min value from list: " + numbers); | ||
return numbers.stream() | ||
.map(string -> string.split(NUMBERS_DIVIDER)) | ||
.flatMap(Arrays::stream) | ||
.mapToInt(Integer::parseInt) | ||
.filter(this::isEven) | ||
.min() | ||
.orElseThrow(exceptionSupplier); | ||
} | ||
|
||
/** | ||
* Given a List of Integer numbers, | ||
* return the average of all odd numbers from the list or throw NoSuchElementException. | ||
* But before that subtract 1 from each element on an odd position (having the odd index). | ||
*/ | ||
public Double getOddNumsAverage(List<Integer> numbers) { | ||
return 0D; | ||
return IntStream.range(0, numbers.size()) | ||
.map(number -> (!isEven(number)) ? numbers.get(number) - 1 : numbers.get(number)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems to be redundant parentheses (!isEven(number)) |
||
.filter(number -> number % 2 == 1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. extract |
||
.average() | ||
.orElseThrow(); | ||
} | ||
|
||
/** | ||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||
* select from the List only men whose age is from `fromAge` to `toAge` inclusively. | ||
* <p> | ||
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||
*/ | ||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||
return Collections.emptyList(); | ||
Predicate<Person> predicate = person -> | ||
person.getSex() == Person.Sex.MAN | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should build construction in this way to avoid NPE and MB use equals. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We compare two enums with equal references, in this case we can use == |
||
&& person.getAge() >= fromAge | ||
&& person.getAge() <= toAge; | ||
Comment on lines
+40
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we mb create a local variable to store person.getAge() value? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is redundant in this place There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should always extract identical expressions into variables
|
||
return peopleList.stream() | ||
.filter(predicate) | ||
.toList(); | ||
} | ||
|
||
/** | ||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||
* select from the List only people whose age is from `fromAge` and to `maleToAge` (for men) | ||
* or to `femaleToAge` (for women) inclusively. | ||
* <p> | ||
* Example: select people of working age | ||
* (from 18 y.o. and to 60 y.o. for men and to 55 y.o. for women inclusively). | ||
*/ | ||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||
int maleToAge, List<Person> peopleList) { | ||
return Collections.emptyList(); | ||
Predicate<Person> predicate = person -> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. predicate name is too generic, it's better to give some name that explains what this predicate does |
||
(person.getSex() == Person.Sex.MAN && person.getAge() <= maleToAge) | ||
|| (person.getSex() == Person.Sex.WOMAN && person.getAge() <= femaleToAge); | ||
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should build construction in this way to avoid NPE and MB use equals. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We compare two enums with equal references, in this case we can use ==
Comment on lines
+50
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. person.getAge() and person.getSex() duplication |
||
return peopleList.stream() | ||
.filter(person -> person.getAge() >= fromAge) | ||
.filter(predicate) | ||
.toList(); | ||
} | ||
|
||
/** | ||
* Given a List of `Person` instances (having `name`, `age`, `sex` and `cats` fields, | ||
* and each `Cat` having a `name` and `age`), | ||
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||
*/ | ||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
return Collections.emptyList(); | ||
return peopleList.stream() | ||
.filter(person -> person.getSex() == Person.Sex.WOMAN | ||
&& person.getAge() >= femaleAge) | ||
.map(Person::getCats) | ||
.flatMap(Collection::stream) | ||
.map(Cat::getName) | ||
.toList(); | ||
} | ||
|
||
/** | ||
* Your help with a election is needed. Given list of candidates, where each element | ||
* has Candidate.class type. | ||
* Check which candidates are eligible to apply for president position and return their | ||
* names sorted alphabetically. | ||
* The requirements are: person should be older than 35 years, should be allowed to vote, | ||
* have nationality - 'Ukrainian' | ||
* and live in Ukraine for 10 years. For the last requirement use field periodsInUkr, | ||
* which has following view: "2002-2015" | ||
* We want to reuse our validation in future, so let's write our own impl of Predicate | ||
* parametrized with Candidate in CandidateValidator. | ||
*/ | ||
public List<String> validateCandidates(List<Candidate> candidates) { | ||
return Collections.emptyList(); | ||
return candidates.stream() | ||
.filter(candidateValidator) | ||
.map(Candidate::getName) | ||
.sorted() | ||
.toList(); | ||
} | ||
|
||
private boolean isEven(int number) { | ||
return number % 2 == 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liveInUkraine.split(DIVIDER_DASH) can be extracted to a separate variable, so we can split only once