have some problems #1961
Closed
have some problems #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Sep 4, 2023
src/App.tsx
Outdated
Comment on lines
11
to
15
| user: getUserById(todo.userId) | ||
| || { | ||
| id: 0, name: '', username: '', email: '', | ||
| }, | ||
| })) as TodoWithUser[]; |
There was a problem hiding this comment.
it's redundant let's just return null
There was a problem hiding this comment.
Not fixed
Suggested change
| user: getUserById(todo.userId) | |
| || { | |
| id: 0, name: '', username: '', email: '', | |
| }, | |
| })) as TodoWithUser[]; | |
| user: getUserById(todo.userId) | |
| })); |
src/App.tsx
Outdated
|
|
||
| const [posts, setPosts] = useState<TodoWithUser[]>(todos); | ||
|
|
||
| const addPost = (post: TodoWithUser) => { |
src/App.tsx
Outdated
| return; | ||
| } | ||
|
|
||
| const newPost: TodoWithUser = ({ |
src/components/TodoInfo/TodoInfo.tsx
Outdated
| const { title, completed, user } = todo; | ||
|
|
||
| return ( | ||
| <article className={`TodoInfo ${completed ? 'TodoInfo--completed' : ''}`}> |
There was a problem hiding this comment.
let's use classNames package for such cases
src/components/TodoInfo/TodoInfo.tsx
Outdated
| <article className={`TodoInfo ${completed ? 'TodoInfo--completed' : ''}`}> | ||
| <h2 className="TodoInfo__title">{title}</h2> | ||
|
|
||
| <UserInfo user={user} /> |
There was a problem hiding this comment.
user can be null let's handle this case here
lerastarynets
suggested changes
Sep 4, 2023
IvanFesenko
suggested changes
Sep 5, 2023
src/App.tsx
Outdated
Comment on lines
11
to
15
| user: getUserById(todo.userId) | ||
| || { | ||
| id: 0, name: '', username: '', email: '', | ||
| }, | ||
| })) as TodoWithUser[]; |
There was a problem hiding this comment.
Not fixed
Suggested change
| user: getUserById(todo.userId) | |
| || { | |
| id: 0, name: '', username: '', email: '', | |
| }, | |
| })) as TodoWithUser[]; | |
| user: getUserById(todo.userId) | |
| })); |
src/App.tsx
Outdated
Comment on lines
53
to
58
| user: getUserById(userId) || { | ||
| id: 0, | ||
| name: '', | ||
| username: '', | ||
| email: '', | ||
| }, |
There was a problem hiding this comment.
Suggested change
| user: getUserById(userId) || { | |
| id: 0, | |
| name: '', | |
| username: '', | |
| email: '', | |
| }, | |
| user: getUserById(userId), |
src/components/TodoInfo/TodoInfo.tsx
Outdated
| const { title, completed, user } = todo; | ||
|
|
||
| return ( | ||
| <article className={`TodoInfo ${completed ? 'TodoInfo--completed' : ''}`}> |
src/components/TodoInfo/TodoInfo.tsx
Outdated
| <article className={`TodoInfo ${completed ? 'TodoInfo--completed' : ''}`}> | ||
| <h2 className="TodoInfo__title">{title}</h2> | ||
|
|
||
| {user !== undefined && <UserInfo user={user} />} |
There was a problem hiding this comment.
Suggested change
| {user !== undefined && <UserInfo user={user} />} | |
| {user && <UserInfo user={user} />} |
src/types/types.ts
Outdated
| email: string; | ||
| }; | ||
|
|
||
| export type TodoWithUser = Todos & { user?: Users }; |
There was a problem hiding this comment.
Suggested change
| export type TodoWithUser = Todos & { user?: Users }; | |
| export type TodoWithUser = Todos & { user: Users | null }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.