add solution #2121
Open
add solution #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayogoharo
approved these changes
Oct 24, 2023
Comment on lines
+7
to
+13
| export const UserInfo: React.FC<Props> = ({ user }) => { | ||
| return ( | ||
| <a className="UserInfo" href={`mailto:${user?.email}`}> | ||
| {user?.name} | ||
| </a> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
[REACT KNOWLEDGE] - Don't render the component if the property that you pass to the component has null or undefined value.
you should check if user is not undefined before render
polosanya
approved these changes
Oct 26, 2023
|
|
||
| export const App = () => { | ||
| const [currentData, setCurrentData] = useState<TodoWithUser[]>(dataList); | ||
| const [title, setTitle] = useState(''); | ||
| const [currennUserId, setCurrentUserId] = useState(0); |
There was a problem hiding this comment.
Suggested change
| const [currennUserId, setCurrentUserId] = useState(0); | |
| const [currentUserId, setCurrentUserId] = useState(0); |
| return usersFromServer.find((user) => user.id === userId) || null; | ||
| } | ||
|
|
||
| const dataList = todosFromServer.map((todo) => { |
There was a problem hiding this comment.
Suggested change
| const dataList = todosFromServer.map((todo) => { | |
| const todosWithUsers = todosFromServer.map((todo) => { |
Would be great to use descriptive meaningful names
| setSelectValid(false); | ||
| } | ||
|
|
||
| const handlerSubmit = (event: React.ChangeEvent<HTMLFormElement>) => { |
There was a problem hiding this comment.
Suggested change
| const handlerSubmit = (event: React.ChangeEvent<HTMLFormElement>) => { | |
| const handleSubmit = (event: React.ChangeEvent<HTMLFormElement>) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK