task solution #2124

dolphinnq · 2023-10-23T19:32:28Z

dsfreedom

Great job. You only need to add labels)

polosanya

Good job! I'm approving it, but please pay attention to the comments)

polosanya · 2023-10-24T14:50:34Z

src/App.tsx

+  const [titleError, setTitleError] = useState(false);
+  const [titlePatternError, setTitlePatternError] = useState(false);


polosanya · 2023-10-24T14:51:47Z

src/App.tsx

+    }
+
+    const newPost = {
+      id: (Math.max(...posts.map(todo => todo.id)) + 1),


Would be great to create a variable\function for that value

polosanya · 2023-10-24T14:51:54Z

src/App.tsx

+      title,
+      completed: false,
+      userId: selectedUserId,
+      user: usersFromServer.find(user => user.id === selectedUserId) || null,


polosanya · 2023-10-24T14:52:30Z

src/App.tsx

+          {titlePatternError && (
+            <span className="error">
+              Only ua and en letters, digits, and spaces are allowed


You could save the error text in the state and use here instead of the boolean value

task solution

74cc8cb

dsfreedom approved these changes Oct 24, 2023

View reviewed changes

polosanya approved these changes Oct 24, 2023

View reviewed changes

Provide feedback

		const [titleError, setTitleError] = useState(false);
		const [titlePatternError, setTitlePatternError] = useState(false);