first solution #2127
Open
first solution #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 24, 2023 01:16
BetterSol
suggested changes
Oct 24, 2023
Comment on lines
+11
to
+13
| const findUserById = (id: number) => { | ||
| return usersFromServer.find(user => user.id === id) || null; | ||
| }; |
There was a problem hiding this comment.
It's better to relocate this function to a separate file.
Comment on lines
+82
to
117
| <form | ||
| action="/api/todos" | ||
| method="POST" | ||
| onSubmit={handleSubmit} | ||
| > | ||
| <div className="field"> | ||
| <input type="text" data-cy="titleInput" /> | ||
| <span className="error">Please enter a title</span> | ||
| <input | ||
| type="text" | ||
| data-cy="titleInput" | ||
| placeholder="Enter a Title" | ||
| value={title} | ||
| onChange={handleTitleInput} | ||
| /> | ||
|
|
||
| {hasTitleError && <span className="error">Please enter a title</span>} | ||
| </div> | ||
|
|
||
| <div className="field"> | ||
| <select data-cy="userSelect"> | ||
| <select | ||
| data-cy="userSelect" | ||
| value={userId} | ||
| onChange={handleUserSelect} | ||
| > | ||
| <option value="0" disabled>Choose a user</option> | ||
| {usersFromServer.map(user => ( | ||
| <option value={user.id} key={user.id}>{user.name}</option> | ||
| ))} | ||
| </select> | ||
|
|
||
| <span className="error">Please choose a user</span> | ||
| {hasUserError && <span className="error">Please choose a user</span>} | ||
| </div> | ||
|
|
||
| <button type="submit" data-cy="submitButton"> | ||
| Add | ||
| </button> | ||
| </form> |
There was a problem hiding this comment.
Consider creating a separate file for a ToDoForm and it's hooks, it will keep your App file more readable
Comment on lines
+54
to
+64
| if (!title) { | ||
| setHasTitleError(!hasTitleError); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (!userId) { | ||
| setHasUserError(!hasUserError); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
I need this to prevent changes and raise individual errors if there are any
| const handleSubmit = ((e: React.ChangeEvent<HTMLFormElement>) => { | ||
| e.preventDefault(); | ||
|
|
||
| if (!title && !userId) { |
There was a problem hiding this comment.
better to use || operator, then you won't need separate conditions below
There was a problem hiding this comment.
Then I will always have both mistakes
src/components/TodoInfo/TodoInfo.tsx
Outdated
Comment on lines
14
to
15
| className={cn('TodoInfo', { | ||
| 'TodoInfo--completed': todo.completed, |
There was a problem hiding this comment.
Guess it's better to move this part to a new variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK