solution #2888
Open
solution #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BudnikOleksii
suggested changes
Dec 12, 2024
src/App.tsx
Outdated
Comment on lines
26
to
27
| setTitleError(false); | ||
| setUserError(false); |
There was a problem hiding this comment.
You don't need reset errors at first
src/App.tsx
Outdated
| setUserError(true); | ||
| } | ||
|
|
||
| if (title.trim() && userId !== 0) { |
There was a problem hiding this comment.
You do title.trim() and userId !== 0 comparasion twice, create variables
src/App.tsx
Outdated
|
|
||
| // import usersFromServer from './api/users'; | ||
| // import todosFromServer from './api/todos'; | ||
| const findUserId = (userId: number) => |
There was a problem hiding this comment.
Suggested change
| const findUserId = (userId: number) => | |
| const findUserById = (userId: number) => |
As I see you are looking for user in this function not for id
src/App.tsx
Outdated
| userId, | ||
| }; | ||
|
|
||
| setTodos([...todos, newTodo]); |
There was a problem hiding this comment.
When you set state depending on the previous one use functional setState
src/App.tsx
Outdated
Comment on lines
47
to
48
| setTitle(''); | ||
| setUserId(0); |
src/App.tsx
Outdated
Comment on lines
20
to
21
| const [titleError, setTitleError] = useState<boolean>(false); | ||
| const [userError, setUserError] = useState<boolean>(false); |
There was a problem hiding this comment.
Boolean variables should start from is or has
src/App.tsx
Outdated
Comment on lines
65
to
68
| onChange={(e: ChangeEvent<HTMLInputElement>) => { | ||
| setTitle(e.target.value); | ||
| setTitleError(false); | ||
| }} |
There was a problem hiding this comment.
Create functions instead of passing anonim function to onChange events
| return ( | ||
| <article | ||
| data-id={todo.id} | ||
| className={`TodoInfo ${todo.completed ? 'TodoInfo--completed' : ''}`} |
There was a problem hiding this comment.
To set classes conditionally use classnames or clsx library
StasSokolov1
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK