Task solution (read description) #2894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some checks were not successful. I'll fix that asap |
BudnikOleksii
approved these changes
Dec 15, 2024
src/App.tsx
Outdated
| })); | ||
|
|
||
| export const App: React.FC = () => { | ||
| const [listTodo, updateTodoList] = useState(todos); |
There was a problem hiding this comment.
Suggested change
| const [listTodo, updateTodoList] = useState(todos); | |
| const [todoList, setTodoList] = useState(todos); |
Developers have a convention on how to name use state https://react.dev/reference/react/useState
src/App.tsx
Outdated
Comment on lines
26
to
29
| updateTodoList([ | ||
| ...listTodo, | ||
| { userId, id, title, user: getUserById(userId), completed: false }, | ||
| ]); |
There was a problem hiding this comment.
When you set state depending on the previous one use functional setState
Comment on lines
42
to
43
| setTitle(title.replace(/[^a-zA-Z0-9 ]/g, '')); // I just didn't want to create a cycle for deleting characters | ||
| } // So I googled this expression |
There was a problem hiding this comment.
If you have a regex create a variable for it and put comments close to it
Comment on lines
13
to
14
| const [titleHasError, setTitleError] = useState(false); | ||
| const [userHasError, setUserError] = useState(false); |
There was a problem hiding this comment.
Fix naming, in accordance with convention and boolean variables should start from is or has
| resetForm(); | ||
| }; | ||
|
|
||
| const titleValidation = (title: string) => { |
There was a problem hiding this comment.
Suggested change
| const titleValidation = (title: string) => { | |
| const validateTitle = (title: string) => { |
Function name should start from verb
Comment on lines
56
to
60
| onChange={event => { | ||
| setTitle(event.target.value); | ||
| titleValidation(event.target.value); | ||
| setTitleError(false); | ||
| }} |
There was a problem hiding this comment.
- Create a function instead of passing anonim one to onChange
- You
setTitlein the validation function
Comment on lines
72
to
75
| onChange={event => { | ||
| setUserId(+event.target.value); | ||
| setUserError(false); | ||
| }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My tests are completely broken because of a mysterious issue — I'm still getting the error "Failed to fetch the module...". So, idk, if it passes the test or not. I compared my code to others and it should work fine...
At least the demo seems to be fine.
DEMO LINK